Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>,
	tarantool-patches@dev.tarantool.org, gorcunov@gmail.com
Subject: Re: [Tarantool-patches] [PATCH 1/2] fiber: make wakeup in Lua and C nop on self
Date: Sun, 25 Apr 2021 17:53:16 +0200	[thread overview]
Message-ID: <0aed8e87-324f-01d0-c5d4-40a06d8006e7@tarantool.org> (raw)
In-Reply-To: <2e89c2b4-fd13-2ca1-9c05-f8e95d2e92e6@tarantool.org>

Thanks for the review!

>> +
>> +local function test_wakeup_self_and_wal_write(test)
>> +    test:plan(1)
>> +
>> +    local s = box.schema.create_space('test')
>> +    s:create_index('pk')
>> +
>> +    fiber.wakeup(fiber.self())
>> +    local lsn = box.info.lsn
>> +    s:replace{1}
>> +    test:is(box.info.lsn, lsn + 1, 'written to WAL')
>> +    s:drop()
>> +end
> 
> Again, shouldn't everything related to space creation, WAL writes and so on
> reside in box-tap ? I may be wrong, just asking.

It should, but this test is about testing the fibers, not
the box. Box and the WAL write here are secondary things.
The same as for app/fiber.test.lua (not TAP).

  reply	other threads:[~2021-04-25 15:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 23:15 [Tarantool-patches] [PATCH 0/2] fiber_wakeup() " Vladislav Shpilevoy via Tarantool-patches
2021-04-23 23:15 ` [Tarantool-patches] [PATCH 1/2] fiber: make wakeup in Lua and C " Vladislav Shpilevoy via Tarantool-patches
2021-04-25  9:21   ` Serge Petrenko via Tarantool-patches
2021-04-25 15:53     ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-04-26  9:21       ` Serge Petrenko via Tarantool-patches
2021-04-23 23:15 ` [Tarantool-patches] [PATCH 2/2] fiber: use wakeup safely on self everywhere Vladislav Shpilevoy via Tarantool-patches
2021-04-25  9:23   ` Serge Petrenko via Tarantool-patches
2021-04-26 21:56 ` [Tarantool-patches] [PATCH 0/2] fiber_wakeup() nop on self Cyrill Gorcunov via Tarantool-patches
2021-04-27 12:03 ` Kirill Yukhin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0aed8e87-324f-01d0-c5d4-40a06d8006e7@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 1/2] fiber: make wakeup in Lua and C nop on self' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox