From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D141E4696C3 for ; Wed, 8 Apr 2020 12:40:40 +0300 (MSK) From: "Timur Safin" References: <8dc7be67-fc78-dd42-0634-83692259f0a5@ocelot.ca> <1433D33E-327F-4365-BB52-8BB9C6B539D5@tarantool.org> In-Reply-To: <1433D33E-327F-4365-BB52-8BB9C6B539D5@tarantool.org> Date: Wed, 8 Apr 2020 12:40:38 +0300 Message-ID: <0ab201d60d89$c39dd5f0$4ad981d0$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: ru Subject: Re: [Tarantool-patches] [PATCH 0/4] session settings fixes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Chris Sosnin' , 'Peter Gulutzan' Cc: tarantool-patches@dev.tarantool.org : -----Original Message----- : From: Tarantool-patches = On : Behalf Of Chris Sosnin :=20 : > On 3 Apr 2020, at 20:09, Peter Gulutzan wrote: : > : > Hi, : > : > Re: : > SETTING SET "sql_default_engine" =3D 'memtx'; : > : > Adding a new reserved word SETTING, without advance notice, : > should be against policy. It causes a slight risk : > of breaking an existing application. : > : > I had hoped for : > UPDATE _SETTINGS_DEFAULT_ENGINE SET VALUE =3D 'memtx'; :=20 : Implementing this syntax would either require creating a table for = each : setting : or adding new keywords, since this is the same as updating tables. :=20 : Moreover, SET VALUE construction also is not supported, so we still = need : to reserve a new word. :=20 : We can borrow another MySQL syntax =E2=80=94 SET SESSION name =3D = value : What do you think about this option? :=20 Peter, after multiple rounds of discussions here (one incompatible way = against another incompatible way) we tend to prefer the simpler syntax SET SESSION sqlconfigname =3D value because it's quite simpler, looks similar to MySQL way (though still is = not part of standard), and would require less intrusive patch to parser. = Introducing all configuration settins as separate system spaces (via = hardcoding in the engine) looked to us slightly more intrusive (while = still being not as much closer to the standard way). Minuses against minuses on both sides.=20 What do you think, Peter? Thanks, Timur