From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8DD3A445320 for ; Wed, 8 Jul 2020 12:13:06 +0300 (MSK) From: Aleksandr Lyapunov References: <1594199230-26036-1-git-send-email-alyapunov@tarantool.org> Message-ID: <0a5f2a55-7233-c34d-74ed-6d601138f945@tarantool.org> Date: Wed, 8 Jul 2020 12:13:05 +0300 MIME-Version: 1.0 In-Reply-To: <1594199230-26036-1-git-send-email-alyapunov@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [Tarantool-patches] [PATCH 0/2] Simplify alter.cc List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org Cc: Vladislav Shpilevoy +Ilya Kosarev and forgot again: GH issue: https://github.com/tarantool/tarantool/issues/5153 GH branch: https://github.com/tarantool/tarantool/tree/alyapunov/gh-5153-simplify-alter-cc On 08.07.2020 12:07, Aleksandr Lyapunov wrote: > Since we use C++ we need to use in a way that benefits its advantages. > As I see, there are tons of try-catch blocks in alter.cc. We should use more modern techniques and approaches. > > Aleksandr Lyapunov (2): > alter: use good c++ style > alter: use proper way to marry C and C++ > > src/box/alter.cc | 418 +++++++++++++++++++++++-------------------------------- > 1 file changed, 177 insertions(+), 241 deletions(-) >