From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BA283469719 for ; Tue, 22 Sep 2020 00:05:28 +0300 (MSK) From: "Timur Safin" References: <20200921195106.96821-1-huston.mavr@gmail.com> In-Reply-To: Date: Tue, 22 Sep 2020 00:05:25 +0300 Message-ID: <0a4d01d6905a$ed4c1110$c7e43330$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Tarantool-patches] [PATCH] Add missed icu symbols List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Vladislav Shpilevoy' , 'HustonMmmavr' , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@gmail.com, alexander.turenko@tarantool.org : From: Vladislav Shpilevoy : Subject: Re: [PATCH] Add missed icu symbols : ... : > +EXPORT(u_strlen) : > +EXPORT(u_uastrcpy) : > +EXPORT(u_austrcpy) : > +EXPORT(u_errorName) : > +EXPORT(u_getVersion) : > +EXPORT(udat_open) : > +EXPORT(udat_setLenient) : > +EXPORT(udat_close) : > +EXPORT(udat_parseCalendar) : > +#if U_ICU_VERSION_MAJOR_NUM >= 55 : > + EXPORT(udat_formatCalendar) : > +#endif : > +EXPORT(ucal_open) : > +EXPORT(ucal_close) : > +EXPORT(ucal_get) : > +EXPORT(ucal_set) : > +EXPORT(ucal_add) : > +EXPORT(ucal_clear) : > +EXPORT(ucal_clearField) : > +EXPORT(ucal_getMillis) : > +EXPORT(ucal_setMillis) : > +EXPORT(ucal_getAttribute) : > +EXPORT(ucal_setAttribute) : > +#if U_ICU_VERSION_MAJOR_NUM >= 51 : > + EXPORT(ucal_getTimeZoneID) : > +#endif : > +EXPORT(ucal_setTimeZone) : > +EXPORT(ucal_getNow) : : 3. Lets better store everything in exports.h. You can add a new : section in this file separated by a comment, that these symbols are : from ICU, to not scatter them among other exports. Also please sort : the exports in the alphabetical order, as it is asked in exports.h : comment. Agreed with Vlad here - keeping all inside of single exports.h would make this code much, much easier to maintain. I'd recommend you to return back to the original idea with using special EXPORT_ICU(name) macros which would expand to EXPORT(U_ICU_ENTRY_POINT_RENAME(name)) _iff_ not U_DISABLE_RENAMING and to EXPORT(name) otherwise. And for +#if U_ICU_VERSION_MAJOR_NUM >= 51 I'd suggest (but not insist) to create yet another wrapper EXPORT_ICU_51UP(name). This would make it looks very consistent with others. Though with 1 usage case it might be overkill. Regards, Timur