From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0970922FF7 for ; Mon, 16 Jul 2018 11:13:49 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qpA4nkx6CCWr for ; Mon, 16 Jul 2018 11:13:48 -0400 (EDT) Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B8C7821070 for ; Mon, 16 Jul 2018 11:13:48 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: raise error for DELETE FROM nonexistent table From: "n.pettik" In-Reply-To: <8ea2b4731ccf9d79140d17f87a6a1ed05f9948d8.1531753721.git.kshcherbatov@tarantool.org> Date: Mon, 16 Jul 2018 18:13:45 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <0D0A4FC9-E74F-4C63-A87B-950215B1F517@tarantool.org> References: <8ea2b4731ccf9d79140d17f87a6a1ed05f9948d8.1531753721.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov > On 16 Jul 2018, at 18:09, Kirill Shcherbatov = wrote: >=20 > Parser didn't raise error when DELETE FROM can't find > a table specified on statement. > As no error was raised, partially-prepared VDBE code > seemed to be generated fine, that was not true. >=20 > Closes #3535. > =E2=80=94 LGTM. It seems that your patch also closes #3511 issue. If so, add also test for that case and ticket number to commit message (to close it automatically).