From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5990A2B924 for ; Sun, 28 Apr 2019 19:36:02 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tWX8TL_nouVk for ; Sun, 28 Apr 2019 19:36:02 -0400 (EDT) Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D26092B943 for ; Sun, 28 Apr 2019 19:36:01 -0400 (EDT) From: "n.pettik" Message-Id: <0CEB3ED4-A19F-49FE-A074-5BD174D7FCF4@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_2C501412-AAF0-4264-9077-49E028041D20" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: [tarantool-patches] Re: [PATCH v1 3/3] sql: make SQL_TARANTOOL_ERROR the only errcode of OP_Halt Date: Mon, 29 Apr 2019 02:35:59 +0300 In-Reply-To: <20190426073705.GB23413@tarantool.org> References: <2b1c4f5e030ffa41069a3839f6ba39826ea739e1.1555072183.git.imeevma@gmail.com> <20190426073705.GB23413@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Imeev Mergen --Apple-Mail=_2C501412-AAF0-4264-9077-49E028041D20 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 26 Apr 2019, at 10:37, Mergen Imeev wrote: >=20 > On Mon, Apr 15, 2019 at 06:19:34PM +0300, n.pettik wrote: >> 'make ... the only errcode of OP_Halt=E2=80=99 -> >> make =E2=80=A6 be the only ... >>=20 >>> On 12 Apr 2019, at 15:34, imeevma@tarantool.org = wrote: >>>=20 >>> After this patch, the only error code that the OP_Halt opcode >>> will work with is SQL_TARANTOOL_ERROR. >>=20 >> So, why do we need it at all now? Let=E2=80=99s use simple flag >> is_aborted like in parser. >>=20 > I could not do it now. > I think we will do this when rc is one of > SQL_OK, SQL_ROW, SQL_DONE or SQL_TARANTOOL_ERROR. This will be in > the next patch-set. That=E2=80=99s OK, but still don=E2=80=99t understand what prevents you = from doing it right now..BTW, I don=E2=80=99t see corresponding patch in the patch-set you=E2=80=99ve already sent (next one). --Apple-Mail=_2C501412-AAF0-4264-9077-49E028041D20 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 26 Apr 2019, at 10:37, Mergen Imeev <imeevma@tarantool.org> wrote:

On Mon, Apr 15, 2019 at = 06:19:34PM +0300, n.pettik wrote:
'make ... the only errcode of = OP_Halt=E2=80=99 ->
make =E2=80=A6 be the only ...

On 12 Apr = 2019, at 15:34, imeevma@tarantool.org wrote:

After this patch, the only error code that the OP_Halt = opcode
will work with is SQL_TARANTOOL_ERROR.

So, why do we need it at all now? = Let=E2=80=99s use simple flag
is_aborted like in = parser.

I could not do it = now.
I think we = will do this when rc is one of
SQL_OK, SQL_ROW, SQL_DONE or SQL_TARANTOOL_ERROR. This will = be in
the next = patch-set.

That=E2=80=99s OK, but still don=E2=80=99t = understand what prevents you from
doing it right now..BTW, I = don=E2=80=99t see corresponding patch in the
patch-set = you=E2=80=99ve already sent (next one).


= --Apple-Mail=_2C501412-AAF0-4264-9077-49E028041D20--