From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5BB0F2F831 for ; Fri, 9 Nov 2018 02:52:03 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fs265jeTApKt for ; Fri, 9 Nov 2018 02:52:03 -0500 (EST) Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B58A72F5A0 for ; Fri, 9 Nov 2018 02:52:02 -0500 (EST) From: "n.pettik" Message-Id: <0A5351C3-C53C-463E-A48F-9B653E464566@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_EBE5F068-6261-4C08-8193-EE529F19E065" Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: [tarantool-patches] Re: [PATCH v8 2/3] sql: return all generated ids via IPROTO Date: Fri, 9 Nov 2018 10:51:52 +0300 In-Reply-To: <81dc397f-aa49-15b2-5416-1f11931a11e5@tarantool.org> References: <53b98187eba28a890db153e97d9c0a2b3759d1dd.1540832830.git.imeevma@gmail.com> <6167E418-CCCC-4596-9E6C-F04C02045456@tarantool.org> <81dc397f-aa49-15b2-5416-1f11931a11e5@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Imeev Mergen , Vladislav Shpilevoy --Apple-Mail=_EBE5F068-6261-4C08-8193-EE529F19E065 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > Hi! Thank you for review! My answer, diff between patches and new > patch below. Changes were made only in commit named by "sql: > return all generated ids via IPROTO". After changes were made and > diff saved I rebased this branch to current 2.1. After this new > patch description were formed, so it is a bit different from > old patch with applied diff. Now LGTM (as well as whole patch-set). --Apple-Mail=_EBE5F068-6261-4C08-8193-EE529F19E065 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
Hi! Thank you for review! My answer, diff between patches and = new
patch below. Changes were made only in commit named by = "sql:
return all generated ids via IPROTO". After changes were made = and
diff saved I rebased this branch to current 2.1. After this = new
patch description were formed, so it is a bit different = from
old patch with applied diff.

Now = LGTM (as well as whole patch-set).
= --Apple-Mail=_EBE5F068-6261-4C08-8193-EE529F19E065--