From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 93388469719 for ; Fri, 2 Oct 2020 15:26:48 +0300 (MSK) From: "Timur Safin" References: <20200929062543.rfjus76ii2lxqodu@tkn_work_nb> In-Reply-To: <20200929062543.rfjus76ii2lxqodu@tkn_work_nb> Date: Fri, 2 Oct 2020 15:26:47 +0300 Message-ID: <09e801d698b7$4c3c36a0$e4b4a3e0$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Tarantool-patches] [PATCH 2.X 3/7] module api: luaT_newthread List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Alexander Turenko' Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org : From: Alexander Turenko : Subject: Re: [PATCH 2.X 3/7] module api: luaT_newthread : : On Thu, Sep 24, 2020 at 08:00:16PM +0300, Timur Safin wrote: : > Exporting `luaT_newthread` as it's necessary for external merger : : But you expose accessors for the temporary Lua state in the later patch. : Built-in merger only uses luaT_newthread() in luaT_temp_luastate(). Good point! Indeed - it would be unnecessary iff we keep luaT_temp_luastate part of module api... But looks like we are not (and would copy corresponding code back to merger' utils code), so we should consider this patch once again as necessary. Timur