From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BAB9022794 for ; Tue, 26 Jun 2018 09:35:05 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YT5wY7m5XFwP for ; Tue, 26 Jun 2018 09:35:05 -0400 (EDT) Received: from smtp18.mail.ru (smtp18.mail.ru [94.100.176.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7809A21FBC for ; Tue, 26 Jun 2018 09:35:05 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 2/2] sql: enable multi-engine tests for SQL References: <9418cbf4-7ffa-3cfd-a544-bd49b5e52a2c@tarantool.org> <006ee2bb-5abc-d612-3a4f-c709d7f3c27f@tarantool.org> From: Vladislav Shpilevoy Message-ID: <095ad7eb-43a3-8871-6123-7e0bb1e70601@tarantool.org> Date: Tue, 26 Jun 2018 16:34:40 +0300 MIME-Version: 1.0 In-Reply-To: <006ee2bb-5abc-d612-3a4f-c709d7f3c27f@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org Thanks for the fixes! See 2 comments below. On 26/06/2018 15:22, Kirill Shcherbatov wrote: >> Did you test sql-tap/ suite? Why is not it in the >> patch? It could be updated automatically using a >> short script that adds the engine setting at the >> beginning of a file. > Ok, I've change constructor to start SQL-TAP test with all engines. > This patch should be merged after than "Vinyl read iterator skips tuples #3477" > >> 1. Just increase vinyl_max_tuple_size to the same value. This >> test should work both for vinyl and memtx. > Ok. > +-- 4 * 1024 * 1024 is higher than vinyl max tuple size > +old_tuple_size = box.cfg.vinyl_max_tuple_size > +box.cfg{vinyl_max_tuple_size = 5 * 1024 * 1024} 1. Not in the test. See where memtx_max_tuple_size is changed. > +_ = space:replace{1, 1, string.rep('a', 4 * 1024 * 1024) } 2. This line it unnecessary diff. > +box.cfg{vinyl_max_tuple_size = old_tuple_size} > >> 2. Vinyl rollbacks failed transactions, but it does not >> rollback the whole transaction on a non-caught exception. > Ok. > +box.rollback() >