From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <roman.habibov@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 12331469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 18 Sep 2020 16:21:49 +0300 (MSK)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
From: Roman Khabibov <roman.habibov@tarantool.org>
In-Reply-To: <20200918123159.GK10599@tarantool.org>
Date: Fri, 18 Sep 2020 16:21:47 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <09393AC5-7D35-4EC3-A423-3EE6288B1E69@tarantool.org>
References: <20200911215115.6622-1-roman.habibov@tarantool.org>
 <20200911215115.6622-3-roman.habibov@tarantool.org>
 <20200916132708.GB10599@tarantool.org>
 <0d1cda9d-43d6-5f5b-01c7-e01c3579ac3f@tarantool.org>
 <20200918123159.GK10599@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 2/6] sql: refactor
 create_table_def and parse
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Hi, Vlad and Nikita!

> On Sep 18, 2020, at 15:31, Nikita Pettik <korablev@tarantool.org> =
wrote:
>=20
> On 17 Sep 16:43, Vladislav Shpilevoy wrote:
>> On 16.09.2020 15:27, Nikita Pettik wrote:
>>> On 12 Sep 00:51, Roman Khabibov wrote:
>>>> Move ck, fk constraint lists and autoincrement info from
>>>> struct create_table_def to struct Parse to make the code more
>>>> reusable when implementing <ALTER TABLE ADD COLUMN>.
>>>>=20
>>>> Needed for #3075
>>>> ---
>>>=20
>>> Does ANSI allow to include constraints in ADD COLUMN statement?
>>=20
>> Yes.
>>=20
>>> Why did you decide to add autoincrement to this list? Was there any
>>> discussion on this subj?
>>=20
>> There is nothing to discuss. It is either a part of the standard or
>> not. Romain said it is (I didn't check though).
>=20
> Unfortunatelly, this is false statement - autoincrement is not a part =
of
> standard (I've checked 2011 edition).

No no, Vlad. Maybe it was misunderstanding, I didn=E2=80=99t say that =
autoinc
is a part of the Standard. My point was the following:

The standard says that the column descriptions in <CREATE> and <ALTER>
are exactly the same. All consrtaints, <DEFAULT> and <COLLATE> are =
allowed.
But <AUTOINCREMENT> is not described in the standard. I suggested (Vlad
didn't mind) to continue this logic and support <AUTOINCREMENT> inside
<ALTER>, because there are no significant restrictions on this. Why =
can=E2=80=99t
we add a sequence to an already existing table?=