From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7B7BD2585B for ; Mon, 9 Jul 2018 06:20:10 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gb5vNYG5oqKU for ; Mon, 9 Jul 2018 06:20:10 -0400 (EDT) Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3B5AB24D20 for ; Mon, 9 Jul 2018 06:20:10 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 0/2] sql: get rid off sqlite3NestedParse References: From: Vladislav Shpilevoy Message-ID: <09326df9-a440-e33b-0e40-5d87f75da82f@tarantool.org> Date: Mon, 9 Jul 2018 13:20:07 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org Cc: Nikita Pettik LGTM. Nikita, please, make a second review. On 04/07/2018 20:17, Kirill Shcherbatov wrote: > As we are going to implement parser as separate library, > we should get rid off sqlite3NestedParse calls. > Last usages in statistics update could be trivially rewrited > to do not start parsing. We manually build AST structures > simmilar to parser did and manually call sql_table_delete_from. > Finilly, I've removed all sqlite3NestedParse mentionings. > > Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3496-no-nested-parse > Issue: https://github.com/tarantool/tarantool/issues/3496 > > Kirill Shcherbatov (2): > sql: get rid off sqlite3NestedParse in clean stats > sql: remove usless sqlite3NestedParse function > > src/box/sql/analyze.c | 39 ++++++++-------- > src/box/sql/build.c | 122 ++++++++++++++++++++++++------------------------ > src/box/sql/delete.c | 6 +-- > src/box/sql/insert.c | 6 +-- > src/box/sql/sqliteInt.h | 14 +++++- > src/box/sql/update.c | 6 +-- > 6 files changed, 97 insertions(+), 96 deletions(-) >