From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alyapunov@tarantool.org>
Received: from smtp21.mail.ru (smtp21.mail.ru [94.100.179.250])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BA24542EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 11 Jun 2020 16:44:51 +0300 (MSK)
References: <20200607140859.5583-1-i.kosarev@tarantool.org>
From: Aleksandr Lyapunov <alyapunov@tarantool.org>
Message-ID: <093060f4-abc7-ab3a-dbe3-421e0a7356dd@tarantool.org>
Date: Thu, 11 Jun 2020 16:44:50 +0300
MIME-Version: 1.0
In-Reply-To: <20200607140859.5583-1-i.kosarev@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH] memtx: fix tuples references on
	concurrent replaces
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Ilya Kosarev <i.kosarev@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for the patch! See my comment below.

On 6/7/20 5:08 PM, Ilya Kosarev wrote:
> +	/*
> +	 * All tuples stored in a memtx space must be
> +	 * referenced by the primary index.
> +	 */
> +	if (state->index->def->iid == 0)
> +		tuple_ref(stmt->new_tuple);
I'm afraid that stmt->new_tuple can be NULL here.
Could you please create another test for this issue when some tuples are 
deleted during snapshot. I bet it will crash.