From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7BF8B422D2B
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 30 Jun 2020 02:18:23 +0300 (MSK)
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
References: <23700741fb309ed1afd98939e1bc9a2fe5b6ea88.1592866585.git.v.shpilevoy@tarantool.org>
 <11a6f0fe-d39f-e9d5-59c6-3dfab7c95d1c@tarantool.org>
 <96da517b-547f-d5f1-823c-f38141a04670@tarantool.org>
Message-ID: <09061add-8ae0-58d7-9d9c-edad718a1b74@tarantool.org>
Date: Tue, 30 Jun 2020 01:18:21 +0200
MIME-Version: 1.0
In-Reply-To: <96da517b-547f-d5f1-823c-f38141a04670@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/1] applier: send heartbeat not
 only on commit, but on any write
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org

Appeared the transactions leak afterwards anyway.

The problem was that txn->fiber was not set to NULL for
regular async transactions anywhere in applier. So they all
leaked.

I made applier on_commit/on_rollback triggers nullify txn->fiber
so it could be freed when commit/rollback are done.