From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0A2DC6ECCE; Wed, 20 May 2026 16:43:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0A2DC6ECCE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1779284637; bh=ITXJJizJCbx9VLrw6f/AN1QISEoc9ezsWsmAjUPUI0A=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=zSFbmU8Wgd/ykDQ2DYBU7QsQoOXwpbJef9fWz2xAjqbatCMssdTKf4lMJ+eCQE8Y4 Eexw02eqkd/9Ua2QknCEHqDKluVxvzfwDpxXJAkpjXgQVIW8hJehqGsIWdP0bY3FAD InOrmSV6IfMeN23MjSxXT6BhLxDqLPNbMbjZIy0E= Received: from send129.i.mail.ru (send129.i.mail.ru [89.221.237.224]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DD1FD6ECCE for ; Wed, 20 May 2026 16:43:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DD1FD6ECCE Received: by exim-smtp-8466d5ddfc-bwjfg with esmtpa (envelope-from ) id 1wPhDG-00000000KzE-2Cr2; Wed, 20 May 2026 16:43:55 +0300 Content-Type: multipart/alternative; boundary="------------fZrIpRXhcjyn5SiOZSap25Uk" Message-ID: <088c6ac2-f063-48ca-a8c7-af0f33f170e8@tarantool.org> Date: Wed, 20 May 2026 16:43:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Mikhail Elhimov , Evgeniy Temirgaleev Cc: tarantool-patches@dev.tarantool.org References: <20260519123913.178775-1-skaplun@tarantool.org> <20260519123913.178775-4-skaplun@tarantool.org> In-Reply-To: <20260519123913.178775-4-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-618D5548: DF94A51FAB97E45415C513EAE8123D4D0DCAD17ADF2E7F14A436CF02A67DB05BA5CB81A3B33F571B X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD98DC58EE55F2C5C37CF4F06BFADE94D3C59738DC6A51B0EA400894C459B0CD1B9DF94A51FAB97E45415C513EAE8123D4D07CD3A8EA2758728A436CF02A67DB05B35340226AAA953E0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76042E2DB3E33BF2BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566BAD382DE516896512B007915E82AA7A83E4DA3ED611CD558C71C7249851D498D389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C376F138C68E4EE6C935872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5E2165A2B749BB7725002B1117B3ED6968C893BF9F3995767E99897350C7C491E823CB91A9FED034534781492E4B8EEADA91A6E18C88C5E2F X-C8649E89: 1C3962B70DF3F0ADB58128AB1E6D661A716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6594044E8A1E1B638AC72F693E80021966F887C32E9CC4473090B762BDAD06D072C99BD4866045F1F1DB8341EE9D5BE9A0A6B7B9A60AFE9285251A0E524060F6A58CA6DB2499C14C6CCC7CEAA0681F5848F4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVax5M0mESuWmD/0LUsMoJHg= X-DA7885C5: 06809C2C1C88787FF255D290C0D534F91C5DF3A124C3D95F8F429633FFAE157D6001EE8A51C77B455B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE2EE04D32A3E13F22DAB1248E54F231553449DE141A0316A3EEF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 3/6] dbg: sort initialization of commands X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------fZrIpRXhcjyn5SiOZSap25Uk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! LGTM Sergey On 5/19/26 15:39, Sergey Kaplun wrote: > This patch sorts the commands for extensions' initialization > alphabetically. Also, it fixes the typo in the lldb extension. > > This allows enabling the loading test for LLDB as well. > --- > src/luajit-gdb.py | 8 ++--- > src/luajit_lldb.py | 8 ++--- > .../debug-extension-tests.py | 30 +++++++++---------- > 3 files changed, 22 insertions(+), 24 deletions(-) > > diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py > index dab07b35..be67bf18 100644 > --- a/src/luajit-gdb.py > +++ b/src/luajit-gdb.py > @@ -872,12 +872,12 @@ def init(commands): > def load(event=None): > init({ > 'lj-arch': LJDumpArch, > - 'lj-tv': LJDumpTValue, > - 'lj-str': LJDumpString, > - 'lj-tab': LJDumpTable, > + 'lj-gc': LJGC, > 'lj-stack': LJDumpStack, > 'lj-state': LJState, > - 'lj-gc': LJGC, > + 'lj-str': LJDumpString, > + 'lj-tab': LJDumpTable, > + 'lj-tv': LJDumpTValue, > }) > > > diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py > index 218cc8d1..7668a94c 100644 > --- a/src/luajit_lldb.py > +++ b/src/luajit_lldb.py > @@ -958,7 +958,7 @@ def register_commands(debugger, commands): > cmd=cls.command, > ) > ) > - print('{cmd} command intialized'.format(cmd=cls.command)) > + print('{cmd} command initialized'.format(cmd=cls.command)) > > > def configure(debugger): > @@ -986,12 +986,12 @@ def configure(debugger): > def __lldb_init_module(debugger, internal_dict): > configure(debugger) > register_commands(debugger, { > - 'lj-tv': LJDumpTValue, > - 'lj-state': LJState, > 'lj-arch': LJDumpArch, > 'lj-gc': LJGC, > + 'lj-stack': LJDumpStack, > + 'lj-state': LJState, > 'lj-str': LJDumpString, > 'lj-tab': LJDumpTable, > - 'lj-stack': LJDumpStack, > + 'lj-tv': LJDumpTValue, > }) > print('luajit_lldb.py is successfully loaded') > diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py > index 11c2492b..f3ce3ced 100644 > --- a/test/tarantool-debugger-tests/debug-extension-tests.py > +++ b/test/tarantool-debugger-tests/debug-extension-tests.py > @@ -125,22 +125,20 @@ class TestCaseBase(unittest.TestCase): > self.assertRegex(self.output, self.pattern.strip()) > > > -# FIXME: Skip for LLDB since it has different order. > -if not LLDB: > - class TestLoad(TestCaseBase): > - extension_cmds = '' > - location = 'lj_cf_print' > - lua_script = 'print(1)' > - pattern = ( > - r'lj-arch command initialized\n' > - r'lj-tv command initialized\n' > - r'lj-str command initialized\n' > - r'lj-tab command initialized\n' > - r'lj-stack command initialized\n' > - r'lj-state command initialized\n' > - r'lj-gc command initialized\n' > - r'.*is successfully loaded' > - ) > +class TestLoad(TestCaseBase): > + extension_cmds = '' > + location = 'lj_cf_print' > + lua_script = 'print(1)' > + pattern = ( > + r'lj-arch command initialized\n' > + r'lj-gc command initialized\n' > + r'lj-stack command initialized\n' > + r'lj-state command initialized\n' > + r'lj-str command initialized\n' > + r'lj-tab command initialized\n' > + r'lj-tv command initialized\n' > + r'.*is successfully loaded' > + ) > > > class TestLJArch(TestCaseBase): --------------fZrIpRXhcjyn5SiOZSap25Uk Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! LGTM

Sergey

On 5/19/26 15:39, Sergey Kaplun wrote:
This patch sorts the commands for extensions' initialization
alphabetically. Also, it fixes the typo in the lldb extension.

This allows enabling the loading test for LLDB as well.
---
 src/luajit-gdb.py                             |  8 ++---
 src/luajit_lldb.py                            |  8 ++---
 .../debug-extension-tests.py                  | 30 +++++++++----------
 3 files changed, 22 insertions(+), 24 deletions(-)

diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py
index dab07b35..be67bf18 100644
--- a/src/luajit-gdb.py
+++ b/src/luajit-gdb.py
@@ -872,12 +872,12 @@ def init(commands):
 def load(event=None):
     init({
         'lj-arch':  LJDumpArch,
-        'lj-tv':    LJDumpTValue,
-        'lj-str':   LJDumpString,
-        'lj-tab':   LJDumpTable,
+        'lj-gc':    LJGC,
         'lj-stack': LJDumpStack,
         'lj-state': LJState,
-        'lj-gc':    LJGC,
+        'lj-str':   LJDumpString,
+        'lj-tab':   LJDumpTable,
+        'lj-tv':    LJDumpTValue,
     })
 
 
diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py
index 218cc8d1..7668a94c 100644
--- a/src/luajit_lldb.py
+++ b/src/luajit_lldb.py
@@ -958,7 +958,7 @@ def register_commands(debugger, commands):
                 cmd=cls.command,
             )
         )
-        print('{cmd} command intialized'.format(cmd=cls.command))
+        print('{cmd} command initialized'.format(cmd=cls.command))
 
 
 def configure(debugger):
@@ -986,12 +986,12 @@ def configure(debugger):
 def __lldb_init_module(debugger, internal_dict):
     configure(debugger)
     register_commands(debugger, {
-        'lj-tv':    LJDumpTValue,
-        'lj-state': LJState,
         'lj-arch':  LJDumpArch,
         'lj-gc':    LJGC,
+        'lj-stack': LJDumpStack,
+        'lj-state': LJState,
         'lj-str':   LJDumpString,
         'lj-tab':   LJDumpTable,
-        'lj-stack': LJDumpStack,
+        'lj-tv':    LJDumpTValue,
     })
     print('luajit_lldb.py is successfully loaded')
diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py
index 11c2492b..f3ce3ced 100644
--- a/test/tarantool-debugger-tests/debug-extension-tests.py
+++ b/test/tarantool-debugger-tests/debug-extension-tests.py
@@ -125,22 +125,20 @@ class TestCaseBase(unittest.TestCase):
             self.assertRegex(self.output, self.pattern.strip())
 
 
-# FIXME: Skip for LLDB since it has different order.
-if not LLDB:
-    class TestLoad(TestCaseBase):
-        extension_cmds = ''
-        location = 'lj_cf_print'
-        lua_script = 'print(1)'
-        pattern = (
-            r'lj-arch command initialized\n'
-            r'lj-tv command initialized\n'
-            r'lj-str command initialized\n'
-            r'lj-tab command initialized\n'
-            r'lj-stack command initialized\n'
-            r'lj-state command initialized\n'
-            r'lj-gc command initialized\n'
-            r'.*is successfully loaded'
-        )
+class TestLoad(TestCaseBase):
+    extension_cmds = ''
+    location = 'lj_cf_print'
+    lua_script = 'print(1)'
+    pattern = (
+        r'lj-arch command initialized\n'
+        r'lj-gc command initialized\n'
+        r'lj-stack command initialized\n'
+        r'lj-state command initialized\n'
+        r'lj-str command initialized\n'
+        r'lj-tab command initialized\n'
+        r'lj-tv command initialized\n'
+        r'.*is successfully loaded'
+    )
 
 
 class TestLJArch(TestCaseBase):
--------------fZrIpRXhcjyn5SiOZSap25Uk--