From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4EB5C6EC5B; Thu, 13 May 2021 16:37:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4EB5C6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620913039; bh=ir+Pvd98OwWWmSBByONSSEAEhRz3U1NY03GRLAQvL4Q=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=lY39jfh48WJSoHyJX6NRQHNDR7RMxr2tKVURn9l0YDwM7rr39NW13mM3HXsHLCfNP mhp/mgWwXg/ozV9Nc4FA6RxqPTOjzz45679ZZ7n30+6nf8C8JBv+3VL/Hm99zC6JDu XOOjs69x/2MnfkynlnsUiqRoDk5QNtIXC60C6qWs= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0E2136EC5B for ; Thu, 13 May 2021 16:37:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0E2136EC5B Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1lhBWf-0008Ed-7X; Thu, 13 May 2021 16:37:17 +0300 To: Vladislav Shpilevoy , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: <20210512112928.12509-1-sergepetrenko@tarantool.org> <73d44826-8840-40d1-b08f-be426eff8c3d@tarantool.org> Message-ID: <088a93c1-d8eb-e4fc-bd5c-5c92e29a0a9b@tarantool.org> Date: Thu, 13 May 2021 16:37:16 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <73d44826-8840-40d1-b08f-be426eff8c3d@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0B2C7F7C3B0039F1303CE517DE434612D182A05F538085040F2A9B99D68C4507C9920A0C4CE3862208F3E3ADB15F57804EBE138255845ED14 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE723A0121E4B9CF535EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375D54B99ECAFA2F678638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B208C2B98B68A5C1F0F6E3E9696F04436544A6ACC89FD899E7D2E47CDBA5A96583C09775C1D3CA48CF329DC2EF12373DEA117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE722C7672CDBCC22789FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE71401CB448F3C6588D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C02CE3825EE585899DCD04E86FAF290E2D7E9C4E3C761E06A71DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6B67FC62909E22F84089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A54EF34DC52F2FCC6CA3D0B9EE7E5C2CBCDC3CCD1AD130EBE3D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342C0B628602DFD0BCDBE09976EA8AFEE334FE6DA718505F8D15EED839A956784911910A6C6798BDD51D7E09C32AA3244CE407E4C2B03B089756132E5A150F1C4230452B15D76AEC14FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoybArHp+PQV411O4GoSuHw== X-Mailru-Sender: 583F1D7ACE8F49BD95918038521BA2AA8C49A680B98EEFD08B89535D47D008C2F3C55668B1428683424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2] recovery: make it yield when positioning in a WAL X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 13.05.2021 14:21, Vladislav Shpilevoy пишет: > Hi! Good job on the fixes! > >> diff --git a/src/box/relay.cc b/src/box/relay.cc >> index 81ac35bf2..efc201e80 100644 >> --- a/src/box/relay.cc >> +++ b/src/box/relay.cc >> @@ -262,8 +262,9 @@ relay_new(struct replica *replica) >> >>  /** A callback recovery calls every now and then to unblock the event loop. */ >>  static void >> -relay_yield(void) >> +relay_yield(struct xstream *stream) >>  { >> +    (void) stream; > For unary operators we omit whitespace after them. > > After you fix this - LGTM! Thanks! Fixed. diff --git a/src/box/relay.cc b/src/box/relay.cc index efc201e80..f721c3346 100644 --- a/src/box/relay.cc +++ b/src/box/relay.cc @@ -264,7 +264,7 @@ relay_new(struct replica *replica)  static void  relay_yield(struct xstream *stream)  { -       (void) stream; +       (void)stream;         fiber_sleep(0);  } -- Serge Petrenko