From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8190C469719 for ; Fri, 16 Oct 2020 15:33:19 +0300 (MSK) From: "Timur Safin" References: In-Reply-To: Date: Fri, 16 Oct 2020 15:33:17 +0300 Message-ID: <086701d6a3b8$86522a50$92f67ef0$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Tarantool-patches] [PATCH] Remove hardcoded paths to LuaJIT tests List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Igor Munkin' , "'Alexander V. Tikhonov'" , 'Alexander Turenko' Cc: tarantool-patches@dev.tarantool.org I could not resist and not highlight the fact that your patch "is not working" the same way as mine :) https://gitlab.com/tarantool/tarantool/-/pipelines/203157106 (Or putting it the other way around - mine was working also. Being less intrusive as patch only for single repository, not 2) LGTM, in any case, if you prefer 2 repo patch. P.S. I do not know whether it means anything, but apparently Debian-based Distros are green now, and RPM-based and others are red. Could it be there anything special which is Debian-specific? : -----Original Message----- : From: Igor Munkin : Sent: Friday, October 16, 2020 3:12 PM : To: Alexander V. Tikhonov ; Timur Safin : ; Alexander Turenko : : Cc: Igor Munkin ; tarantool-patches@dev.tarantool.org : Subject: [PATCH] Remove hardcoded paths to LuaJIT tests : : As a result of the review[1] for Timur patch, I've finally got the idea : how to reduce the struggling Kirill faces every time there is a new test : created within LuaJIT third party repo. The series contains of two : patches in both repos: : * the root CMakeLists.txt for test directory is introduced to LuaJIT : repo in scope of the first patch : * the paths in test/CMakeLists.txt are accordingly adjusted : : Issue: https://github.com/tarantool/tarantool/issues/5425 : LuaJIT repo branches: : * https://github.com/tarantool/luajit/tree/imun/gh-5425-luajit-tests-cmake : * https://github.com/tarantool/luajit/tree/imun/gh-5425-luajit-tests- : cmake-2.5 : Tarantool repo branch (need to be cherry-picked to all stable branches): : * https://github.com/tarantool/tarantool/tree/imun/gh-5425-luajit-tests- : cmake : : CI is not green, but I've done my best. I see neither build fails nor : failures related to the luajit-tap tests here: : * https://gitlab.com/tarantool/tarantool/-/pipelines/203537445 : : [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020- : October/020266.html : : -- : 2.25.0