From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5EF0D4C880; Sun, 10 Jan 2021 17:36:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5EF0D4C880 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610289420; bh=AMBuE04MzQMZHtNUozf/nVKcv7R2hpx8mtFvmbsp2PQ=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=gIbEjZiqJprtsL4XIJXUZNUMRFURMzWY0vLyJnOaJGra/WK1HUCZXVHSGn9ej/oEv X3IIkG0bAEulhLw2jaq8N3OZsY2DedsmXTurvK33lYpp/yW0efyCp3FpyQqZDyO3TW 86qPQtX06mw8fiolD2tbO9YPeXupFNWJbIgVR01c= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A9C304C880 for ; Sun, 10 Jan 2021 17:36:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A9C304C880 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1kybpx-0003w6-Nj; Sun, 10 Jan 2021 17:36:58 +0300 To: mechanik20051988 , alyapunov@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: Message-ID: <0858ff0c-ef9b-aa6c-ebd2-966ce501620e@tarantool.org> Date: Sun, 10 Jan 2021 15:36:56 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CD3BE40D5FE7B3134676ED03235248932300894C459B0CD1B95579F7D9EFFB1B117A7B8E8037E36547B55B255C021CA5FF8A1CF08F9A3DEB66 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7370F4F695FFFC24BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374D0D183F14C070BA8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCFFDE1474D19ACA2762218F47E293E11F1419AEA98206850C389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0F6FAE79CA2B8C2908941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D082881546D93491CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC5F776F440A11DA6975ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4931B544F03EFBC4D57834E4788B0B27831C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0FECB2555BB02FD5A93B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5B8C39FAB898C1E43422B44FD63B793FE1C16DE219A45E5F8D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348F1757F8DFBC5C3366798D378A93F2EACDED35CD5D7DB443B8CF6488151F9EC6370C5A130AEE6B4A1D7E09C32AA3244C7B7FAD61867448F5046CA9B5698D69711E098CBE561D6343FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrM+fB0klCkYEfdT2bNqWcg== X-Mailru-Sender: 689FA8AB762F73937240DDB2502DDB7073FBC91220DF8FC7F4B52380620D0FD03841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 0/4] Choose allocator mor memtx X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Second attempt to send this email. --------------------------------- Hi! Thanks for the patchset! I didn't review the code yet. Only the commit messages. But already can give some comments. On 29.12.2020 12:03, mechanik20051988 via Tarantool-patches wrote: > Branch: https://github.com/tarantool/tarantool/tree/mechanik20051988/gh-5419-choose-allocator-for-memtx-cpp-14 > (Do not pay attention to the number 14 in the branch header) > Issue: https://github.com/tarantool/tarantool/issues/5419 > Pull request: https://github.com/tarantool/tarantool/pull/5670 > About patches: > 1. First patch add performance test for memtx allocator. You can copy perf folder > to master branch and compare performance. > 2. Second patch convert some *.c files to *.cc files. > This is the preparation for the patch with allocator choise > 3. Third patch implement api for allocator choise > 4. Fourth patch add system allocator based on malloc and free > > This is a completely redesigned patch, however I would like to provide answers > to some questions from the previous patch that may overlap > > 1. malloc_usable_size / malloc_size has different headers in different OS, so i use > TARGET_OS_*** to check this in source file not in CMakeLists > 2. I test snapshot using checkpoint_interval=5 option, several snapshots > are created during my test And I said in private that it not only makes the test run at least 5 seconds, which is way too long. But also is not any different from calling box.snapshot() manually. Please, use box.snapshot().