From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A56A930B19
	for <tarantool-patches@freelists.org>; Thu,  6 Jun 2019 14:22:51 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id gf7TiprqdO_X for <tarantool-patches@freelists.org>;
	Thu,  6 Jun 2019 14:22:51 -0400 (EDT)
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1BAE8304B8
	for <tarantool-patches@freelists.org>; Thu,  6 Jun 2019 14:22:51 -0400 (EDT)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: [tarantool-patches] Re: [PATCH v2 0/9] sql: cleanup code from
 obsolete macros
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <cover.1559138377.git.szudin@tarantool.org>
Date: Thu, 6 Jun 2019 21:22:48 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <08530D5F-C413-4E0E-8251-DC61DFD24BED@tarantool.org>
References: <cover.1559138377.git.szudin@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: szudin@tarantool.org



> On 29 May 2019, at 17:01, Stanislav Zudin <szudin@tarantool.org> =
wrote:
>=20
> The patch removes unused constants and macros
> The 2nd version returns back the SQL_OMIT_AUTOMATIC_INDEX and
> the code enabled by this macro.
> Removes the remains of the multithreading from the VDBE's=20
> sorting tools.
> Enables output of number of scanned rows when EXPLAIN
> keyword is used. Updates the affected tests.

Generally speaking, patch-set is OK since it provides
straightforward refactoring. But I would whether squash
all these patches or change their description and group
by thematic topics (like sql: remove unused macros
connected with memory management system).
It=E2=80=99s up to you.