From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 31271219DF
	for <tarantool-patches@freelists.org>; Tue, 25 Dec 2018 12:26:23 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id zZvfjSfRmiCr for <tarantool-patches@freelists.org>;
	Tue, 25 Dec 2018 12:26:23 -0500 (EST)
Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7E5B7219AF
	for <tarantool-patches@freelists.org>; Tue, 25 Dec 2018 12:26:22 -0500 (EST)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
Subject: [tarantool-patches] Re: [PATCH v1 1/3] sql: clean-up
 vdbe_emit_constraint_checks
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <ec9419a6c0f69d93eb0f6d71445b040f0b814bde.1545233551.git.kshcherbatov@tarantool.org>
Date: Tue, 25 Dec 2018 19:26:19 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <083A3DBF-8AF5-45BA-AC5E-E11D5A610533@tarantool.org>
References: <cover.1545233551.git.kshcherbatov@tarantool.org>
 <ec9419a6c0f69d93eb0f6d71445b040f0b814bde.1545233551.git.kshcherbatov@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>



> On 19 Dec 2018, at 17:37, Kirill Shcherbatov =
<kshcherbatov@tarantool.org> wrote:
>=20
> Removed vdbe code generation making type checks from
> vdbe_emit_constraint_checks as it is useless since strict types
> have been introduced.
>=20
> Needed for #3850

It doesn=E2=80=99t seem to be needed for #3850.
Otherwise explain why it is required for #3850.
Patch is OK.