From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2D8507030F; Thu, 25 Feb 2021 00:46:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2D8507030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614203176; bh=5yefOMYZMyp55o2s3EyFkavm5rPgjcGhnmM9mm6/qbk=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=QPrcXyxzBNf0QQh25XYuU6lc6XsaQLL4caxKhZTNtD1H7m/gLlK+uA5riJ4YAgE4N 6ZyRYFy7+bIdzGful192fu5rNU6NZfz3oxiYDogDcfOPVVdH7zGEXnWZ4T68I1wx2M lP0LK2EO/jN34OLUFx/mOefMJ+l2IwZzm+JCt7jU= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 277AE7030F for ; Thu, 25 Feb 2021 00:46:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 277AE7030F Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1lF1z4-0001EQ-7l; Thu, 25 Feb 2021 00:46:14 +0300 To: Oleg Babin , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org References: <627b3c57-d8a9-5681-fb4d-38d0053c6aa7@tarantool.org> Message-ID: <0810bac1-dfaf-6db5-fdf0-65e26f243e1e@tarantool.org> Date: Wed, 24 Feb 2021 22:46:12 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <627b3c57-d8a9-5681-fb4d-38d0053c6aa7@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD975C3EC174F5669228C980786C9DBA186ED94931C77F7596E182A05F538085040A33C30929DFE8B905E9D36174F61F26B3B0D66C4EB97BA0024EF63EDF9EF2F6D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78E8764B5BC580342EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DEEC83A7CF8598608638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC0082003E75549F94C6EB677896BCD641E14C6C705345388F389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A29E2F051442AF778941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6AEEA5BB16A939343CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22495C137F56075BEB0576E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8BFECE6E67438A38413AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE7B2B7C64F398C741067F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C376F138C68E4EE6C935872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9AE7E30DF62CE24E4E5BFE6E7EFDEDCD789D4C264860C145E X-B7AD71C0: 14C14B24D00AF5AC321EF223B8115265C69B993890792DF82CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46DC5868981FE78424C355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A5F82B366ECD86BCBA3DC1E9CE3D5A6199929ACF232F9B2D4FD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7557E988E9157162368E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347341ACA13FB8BDD992BBADCD8AD8141426892DB5410C900EA91FBFE4DA07875BE89044C58B5DCE061D7E09C32AA3244C4A94AC922C639FE23785744FD1F24191250262A5EE9971B0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojvz1c9SWJtj/qvuKsnsEnpQ== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA311005E3CD04E4C0EF91ED3E0968E7046F6E68D1E2F21390247F07784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 01/11] error: introduce vshard.error.timeout() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the review! On 24.02.2021 11:27, Oleg Babin wrote: > Hi! Thanks for your patch. > > Personally, I vote for dropping 1.9 support (it's already broken - #256). It kind of works. Just with some spam in the logs. But yeah, I would like to finally drop it. I talked to Mons and he approved this: https://github.com/tarantool/vshard/issues/267 > But if you want to eliminate "long and ugly" ways you could do something like: > > > ``` > > local make_timeout > if box.error.new ~= nil then >     make_timeout = function() return box.error.new(box.error.TIMEOUT) end > else >     make_timeout = function() return select(2, pcall(...)) end > end > > ``` Which is longer and uglier, right? Where is the win?