From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 004BD45C304
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  1 Dec 2020 13:54:15 +0300 (MSK)
References: <cover.1606766417.git.sergeyb@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <078cfd39-f07c-3f7c-8023-9b8b584d7d71@tarantool.org>
Date: Tue, 1 Dec 2020 13:54:14 +0300
MIME-Version: 1.0
In-Reply-To: <cover.1606766417.git.sergeyb@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH 0/4] Add fuzzing testing
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org, imun@tarantool.org


30.11.2020 23:24, sergeyb@tarantool.org пишет:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
>
> Patch series adds required support in project infrastructure for fuzzing tests,
> add tests for uri, csv and http_parser modules, adds integration with OSS Fuzz
> (infrastructure for continuous running fuzzing tests).
>
> NOTE: v2 version had LGTM from Sergey Petrenko, see [1]
>
> Changelog:
>
> v2:
> - introduce CMake flag to enable building fuzzers
> - add fuzzers based on LibFuzzer to csv, http_parser and uri modules
>
> v3:
> - report error on an attempt to set ENABLE_FUZZER=ON with GCC compiler
> - fixed return code in tests
> - place tests to a common dir test/fuzz/ like we did with unit tests
> - enable building fuzzers in Tarantool CI job
> - add target to build all availabe fuzzers
> - add integration with OSS Fuzz [2]
> - add corpus for uri, csv and http_parser tests
>
> 1. https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/016471.html
> 2. https://github.com/google/oss-fuzz/pull/4723
>
> CI: https://gitlab.com/tarantool/tarantool/-/pipelines/223112908
> Issue: https://github.com/tarantool/tarantool/issues/1809


Hi! Thanks for the patchset!

Generally LGTM with one question.


>
> Sergey Bronnikov (4):
>    test: add infrastructure for fuzzing testing and fuzzers
>    test: add corpus to be used with fuzzers
>    travis: build tarantool with ENABLE_FUZZER


Why travis? Don't we use gitlab for all the QA jobs?
Is travis.mk shared between gitlab and travis?


>    test: integrate with OSS Fuzz
>
-- 
Serge Petrenko