From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounces@dev.tarantool.org>
Received: from [87.239.111.99] (localhost [127.0.0.1])
	by dev.tarantool.org (Postfix) with ESMTP id 094F770200;
	Sun, 31 Jan 2021 20:46:07 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 094F770200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev;
	t=1612115167; bh=Pq8SoRy4T5BHH2wP7oi5TKUPmGLyMdgby8K3Nlv6O5w=;
	h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	 From;
	b=B+6VC++fE2a5t0rEkFc8bCCfuG+EXzJBsK+e/soPySoyIdSrwglZOFLvyw1bHj97r
	 CMjnQbis7oH/PVO/MoRF4I9cu8Nk3kONk2R2xvmbBrKp6R9/yXC6Cv+iHGJnUXklPB
	 OA2CjSufVKgM8i0JfXQVdIcLF4RwL8QPCinhxjmA=
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9668870200
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 31 Jan 2021 20:46:05 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9668870200
Received: by smtpng3.m.smailru.net with esmtpa (envelope-from
 <v.shpilevoy@tarantool.org>)
 id 1l6GnV-0007OM-0i; Sun, 31 Jan 2021 20:46:05 +0300
To: Cyrill Gorcunov <gorcunov@gmail.com>,
 tml <tarantool-patches@dev.tarantool.org>
References: <20210121171753.186891-1-gorcunov@gmail.com>
 <20210121171753.186891-4-gorcunov@gmail.com>
Message-ID: <07446e4c-aabf-bbd7-facb-eeeda5472ae7@tarantool.org>
Date: Sun, 31 Jan 2021 18:46:03 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <20210121171753.186891-4-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-7564579A: 646B95376F6C166E
X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9CC9F923E808BA4A11AAD7C69F0036037C182A05F538085040E6A6E3132B5C54528216D40023D069381F7FA40DBBB3D58266C0556A8BBC64E3
X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A27CE1C94F35B64FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637A30DEE222272883C8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC6FC3BC18456BD4FD4F435866E2FBD4E7CA61067C77DBF4D2389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6E5E764EB5D94DBD4CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC47E915A23788DB9575ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E73564E4DC1543031AB7C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0FECB2555BB02FD5A93B503F486389A921A5CC5B56E945C8DA
X-C1DE0DAB: 0D63561A33F958A57E65DE08E86C456CF8C193943A1A29B1CEDD70D5C424DD0DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0
X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34728AF701C68E453936D52AA6FBACD17F22C3FE9CAD4E1C9029AF969939E2BE3418B24C47B2DA912D1D7E09C32AA3244CF5E13D9ADEB42F652CAE4F162B63158539C99C45E8D137E9FACE5A9C96DEB163
X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojyKiJYJ15DtIyb2rGy8cELQ==
X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822B1B30ACAE457C279DC48C73C05A5ED273841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B
X-Mras: Ok
Subject: Re: [Tarantool-patches] [PATCH 3/3] test: replication/status --
 fetch downstream lag field
X-BeenThere: tarantool-patches@dev.tarantool.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
From: Vladislav Shpilevoy via Tarantool-patches
 <tarantool-patches@dev.tarantool.org>
Reply-To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Errors-To: tarantool-patches-bounces@dev.tarantool.org
Sender: "Tarantool-patches" <tarantool-patches-bounces@dev.tarantool.org>

Thanks for the patch!

> diff --git a/test/replication/status.result b/test/replication/status.result
> index a8c515dbb..e59694730 100644
> --- a/test/replication/status.result
> +++ b/test/replication/status.result
> @@ -186,6 +186,14 @@ test_run:wait_cond(function()                    \
>  ---
>  - true
>  ...
> +-- once replication vclock is reached there
> +-- should be non infinity downstream lag, set
> +-- it to some sane value but not short since
> +-- there might be network lags on a low level

At least in the tests try to start sentences with a capital
letter and end them with a period. Also for tests related to a
ticket we add 'gh-####: ` to the beginning of the comment.

> +replica.downstream.lag ~= nil and replica.downstream.lag < 60
> +---
> +- true
> +...