From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D1DA0445320
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 23 Jul 2020 23:58:54 +0300 (MSK)
References: <1594821336-14468-1-git-send-email-alyapunov@tarantool.org>
 <1594821336-14468-14-git-send-email-alyapunov@tarantool.org>
 <dafae4b9-da65-00d4-b322-bdc4fa8c9635@tarantool.org>
 <9236c217-eaa5-28be-6e14-953b18aa0efa@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <06d6b715-5658-579e-de5a-5b264a81c507@tarantool.org>
Date: Thu, 23 Jul 2020 22:58:53 +0200
MIME-Version: 1.0
In-Reply-To: <9236c217-eaa5-28be-6e14-953b18aa0efa@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 13/13] tmx: use new tx manager in
 memtx
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Aleksandr Lyapunov <alyapunov@tarantool.org>, tarantool-patches@dev.tarantool.org

> On 7/17/20 1:26 AM, Vladislav Shpilevoy wrote:
>> Th
>> 1. You can pass tx_manager_use_mvcc_engine as a second
>> argument to txn_can_yield() instead of adding one another
>> 'if'.
> Actually it's not so simple. It would fall in assert.

Well, then remove the assert. Better patch txn_can_yield(),
that what you did. You just moved the common 'if' out of
the function and added it to each call, even though you
could move it inside.