From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ED5467030C; Mon, 24 May 2021 18:47:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ED5467030C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1621871226; bh=g9szRs9McUzWoMeEH1cLIrCA4IN63slxJn/b5Gtz4uQ=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=fbkOFB93iMb/x0nLUb4IkZwg+qDdfTkvRdx+rGqEzhaE1pNYdgGCTeoMtmzVxShjh Gygo+f56kAXzyBI4xgwciyupR84yAbH5oApO1442GhQqH+IXFkU1dg5nQ8CRb4Hqyj MfNAocvMOBYmCuA+bTU99kKpktbycHRC+wIXPqmo= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 349077030C for ; Mon, 24 May 2021 18:47:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 349077030C Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1llCnI-0001D7-8T; Mon, 24 May 2021 18:47:04 +0300 To: Serge Petrenko , tarantool-patches@dev.tarantool.org, olegrok@tarantool.org References: <2fb4c066558879eea74acab2e20b8a1c8f85d86b.1621778740.git.v.shpilevoy@tarantool.org> <65ce8ac8-6af3-e822-9fb0-113b37f51b18@tarantool.org> Message-ID: <063bf9bd-2fbc-136a-a75e-44e6942ec57d@tarantool.org> Date: Mon, 24 May 2021 17:47:03 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <65ce8ac8-6af3-e822-9fb0-113b37f51b18@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91B019B01C53E51AFBEA66046F15EAF23C5E2F255C2D74AA700894C459B0CD1B91786F3A0E7C38B6E0DB441559B6BFFF88E2CFE174D4D9C6F97B8945207C55574 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A8325FA649D0A450EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D70459430292EC88638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B8349159C40413CB69C186C5A76333DB117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6B1CFA6D474D4A6A4089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5CE3FE458FA27DFF25E4C00A9698B4B33667E313ED619CBC0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753C350047980234DB410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F804B400765FFFF9C74427A724FD1CE42B0852D5622C3FC1E67BC057E816C42180B890CCCAEC704D1D7E09C32AA3244CA94C84A9F3E4C7DD64DA4AAF689EA360F165894D92D62706FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+gjVyQcIK6ICBPFb9B+maQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822CCDF118FA1C98563BA17852BE6E5A9A03841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/1] json: use cord_ibuf for encoding and decoding X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the review! > Sorry, I noticed this too late: luacheck has one warning on your branch: > > Checking test/app-tap/json.test.lua 1 warning > 422 > 423 test/app-tap/json.test.lua:210:9: (W213) unused loop variable i > 424 Fixed: ==================== @@ -207,7 +207,7 @@ tap.test("json", function(test) -- local bigstr = string.rep('a', 16384) local t = {} - for i = 1, 10 do + for _ = 1, 10 do table.insert(t, bigstr) end local bigjson = serializer.encode(t) ====================