From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 18DFF2BAA6 for ; Thu, 18 Apr 2019 16:40:49 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pqPzmHnlB4sx for ; Thu, 18 Apr 2019 16:40:49 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C71132AC55 for ; Thu, 18 Apr 2019 16:40:48 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 7/6] swim: drop incarnation_inc parameter from update() routines References: <2e76a679-c509-f12e-5abb-b1457ca478b0@tarantool.org> <20190418182019.GA26665@chai> From: Vladislav Shpilevoy Message-ID: <061b337a-c9fd-4bb4-d58b-4ee7327f8c6c@tarantool.org> Date: Thu, 18 Apr 2019 23:40:46 +0300 MIME-Version: 1.0 In-Reply-To: <20190418182019.GA26665@chai> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Konstantin Osipov Pushed into the master. On 18/04/2019 21:20, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/04/18 21:18]: >> Update_addr and update_payload need to increment member's >> incarnation when it is self. For that they used a special >> parameter incarnation_inc set in 1 for self and in 0 for others. >> >> It was used to encapsulate incarnation update + event scheduling >> on member attribute updates, but on the other hand it broke >> another encapsulation level - there should not be exceptions for >> 'self' in these functions. >> >> This patch makes incarnation increment explicit in the places >> where 'self' is updated. > > ok to push > > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >