From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 69E327030C; Tue, 9 Feb 2021 16:59:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 69E327030C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1612879178; bh=76TGTQbEbL2+ozGPzhWiAP2xDR6zbHfZE9i+bCGJ1Uw=; h=To:References:In-Reply-To:Date:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MR+cQfJ0p5r9ukpyNQgFMgA7+lPcdy79EDEsyAhymGk0Bm8sQkRm4SgPKaarBj/lD 0sXO8ilhBkboVNsjDvl03B1WLRR3rEkXYzMygRp5Wxb7gWO2teYNnDb67sSGploLnu FAfo3BqW/VZKvXLNFvJVW4KUawwkST3y4If4lJ3s= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D7D617030C for ; Tue, 9 Feb 2021 16:59:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D7D617030C Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1l9TYC-0003Oc-SP; Tue, 09 Feb 2021 16:59:33 +0300 To: "'Igor Munkin'" References: <6a03d693204cacc5791c75e1003efc150abb2979.1612291495.git.imun@tarantool.org> <01d401d6fe2b$dd80c160$98824420$@tarantool.org> <20210208162930.GF5448@tarantool.org> <044301d6febb$ef1af8b0$cd50ea10$@tarantool.org> <20210209084319.GG5448@tarantool.org> In-Reply-To: <20210209084319.GG5448@tarantool.org> Date: Tue, 9 Feb 2021 16:59:29 +0300 Message-ID: <05ba01d6feeb$c962bfb0$5c283f10$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJPfenCWrjRxS0krGRZARdqgOlJ3gIL945VAa2c2BwBg+GQKwIKJMJTAZTvSR+pF/ZwQA== Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9CD7A046B9B594DE544EF4829CAF723B1F182A05F5380850404F704B08C5482352B92117D7BACE5E7502D0DE059989F08AACAF8FED8811787D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE727FD6E7FC3A8F857EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373D58C44ED3182E498638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC23A03A9B45077CD59C6EADAC0CCBE3897B65782002C7B544389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249D74C6C6B0256B22D76E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8BCF01C05423B8DB1BD81D268191BDAD3D698AB9A7B718F8C442539A7722CA490C13377AFFFEAFD26923F8577A6DFFEA7CAA44A86D94E7BBB093EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B642416645EBD45DC2089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E702E4EE3A04994FF497E5BFE6E7EFDEDCD789D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5F82A978EAC0B9856D05D14CC572B445AD692A8608072B65AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3473457D764E1CDE77B8B4105E8133DFB3DAD2F031440628FD0549B9A3CC4B3481F9A5C9C1E85ABEC91D7E09C32AA3244CF9DCE1DED7D0362198EED4F42AF29FDF51E887DA02A9F7BFFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojg67HQLCbniIN+KMDmyDzZQ== X-Mailru-Sender: 6CA451E36783D721CBEA96CEA26D325DFEE8A44591F620439FE29FBE034BB766B7CBEF92542CD7C82F97C478340294DCC77752E0C033A69E0F0C7111264B8915FF1320A92A5534336C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/5] test: run LuaJIT tests via CMake X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Timur Safin via Tarantool-patches Reply-To: Timur Safin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" LGTM.=20 Modulo my usual note about 2nd comment about cmake. But you may already = has it fixed in your branch till this moment... : From: Igor Munkin : Subject: Re: [PATCH luajit 3/5] test: run LuaJIT tests via CMake :=20 : > : : > : Unfortunately... CMake is a crap and I can't fix it. Well, = honestly I : > : don't want to fix it. But you're right: I can fix all these = comments : > : (athough I don't really want to). I have no idea how to express = this in : > : a more neutral way, so I propose the following: : > : 1. s/CMake is a crap/there is no convenient way to make it in = CMake/g. : > : 2. Leave everything else unchanged. : > : > Hmm, ok. :=20 : Fixed, squashed, force-pushed to the branch. Diff is below: Nice! Thank you! But there is 2nd one... :=20 : > : > : : > : This is not only emotions. Such comments prevent one from = unintentional : > : refactoring of such fragile places with no failures and also from : > : bothering the oldies with the questions kinda "dude, why is this = done so : > : badly". In other words, primarily I have left this for the = history. : > : : > : If you're OK, then I'll fix the way described above. : > : : > : > : > : > : + # Add the directory where the lib is built to the LUA_CPATH : > : > : + # environment variable, so interpreter can find and load = it. : > : > : + # XXX: Here we see the other side of the coin. If one joins = two : > : > : + # strings with semicolon, the value automatically becomes = the : > : > : + # list. I have no idea what is wrong with this tool,=20 About this one ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ : > : > : + but I found : > : > : + # a single working solution to make LUA_CPATH be a string = via : > : > : + # "escaping" the semicolon right in string interpolation. : > : > : + set(LUA_CPATH : > : > : : > : Regards, Timur