From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1B530469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 May 2020 01:21:11 +0300 (MSK)
References: <30d78005ea9ea576b7ba4c3065c2c60ab91a9408.1590592525.git.avtikhon@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <05b4faaa-0fc3-2cb4-cdba-c04d43c462e3@tarantool.org>
Date: Thu, 28 May 2020 00:21:10 +0200
MIME-Version: 1.0
In-Reply-To: <30d78005ea9ea576b7ba4c3065c2c60ab91a9408.1590592525.git.avtikhon@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v1] test: fix box/push.test.lua for
	ASAN
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>, Oleg Piskunov <o.piskunov@tarantool.org>, Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

I sent an alternative fix in a new email thread. Check it out.

> diff --git a/asan/asan.supp b/asan/asan.supp
> index 79c13ec7d..b806873a5 100644
> --- a/asan/asan.supp
> +++ b/asan/asan.supp
> @@ -9,6 +9,10 @@
>  # source: third_party/lua-cjson/lua_cjson.c
>  fun:json_decode
>  
> +# test: box/push.test.lua
> +# source: src/lib/msgpuck/hints.c:39:20
> +src:*src/lib/msgpuck/hints.c

Why did you use '*' in the beginning though it is
not used on other 'src:' lines?