From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alyapunov@tarantool.org>
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2D6C0430407
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 10 Aug 2020 13:10:08 +0300 (MSK)
References: <cover.1596584571.git.v.shpilevoy@tarantool.org>
From: Aleksandr Lyapunov <alyapunov@tarantool.org>
Message-ID: <05992d38-6a4a-4e2e-db6e-041c4184d7e7@tarantool.org>
Date: Mon, 10 Aug 2020 13:10:06 +0300
MIME-Version: 1.0
In-Reply-To: <cover.1596584571.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH 0/2] JSON field multikey crash
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org, korablev@tarantool.org

Hi! thanks for the patch.
Btw, why do we call them 'JSON fields'? Is it supposed that it should 
work somehow
with Java Script Object Notation serialization format?

On 8/5/20 2:45 AM, Vladislav Shpilevoy wrote:
> The patchset fixes 2 crashes related to multikey in JSON path
> tuple field access code.
>
> Also during working on this I found
> https://github.com/tarantool/tarantool/issues/5226, but couldn't
> find a simple solution.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5224-tuple-field-by-path-crash
> Issue: https://github.com/tarantool/tarantool/issues/5224
>
> @ChangeLog
> * Fixed a crash when JSON tuple field access was used to get a multikey indexed field, and when a JSON contained [*] in the beginning;
>
> Vladislav Shpilevoy (2):
>    tuple: fix multikey field JSON access crash
>    tuple: fix access by JSON path starting from '[*]'
>
>   src/box/tuple.c                               |   3 +-
>   src/box/tuple.h                               |   8 +
>   test/box/gh-5224-multikey-field-access.result | 164 ++++++++++++++++++
>   .../gh-5224-multikey-field-access.test.lua    |  72 ++++++++
>   4 files changed, 246 insertions(+), 1 deletion(-)
>   create mode 100644 test/box/gh-5224-multikey-field-access.result
>   create mode 100644 test/box/gh-5224-multikey-field-access.test.lua
>