From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 514F729880 for ; Mon, 1 Apr 2019 09:44:07 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9X_8ukTnh8fq for ; Mon, 1 Apr 2019 09:44:07 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EF26829755 for ; Mon, 1 Apr 2019 09:44:06 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: parameter binding for box.execute() References: <884040abe819e8ec11f7877d15e5482d6a24139b.1553947026.git.imeevma@gmail.com> <20190401052112.GB8239@chai> <648b0ae4-35e0-9df0-1a67-712788727b79@tarantool.org> <20190401130544.GA2628@chai> From: Vladislav Shpilevoy Message-ID: <05765e13-bc1e-e52b-e1c4-c749c4518e6c@tarantool.org> Date: Mon, 1 Apr 2019 16:44:03 +0300 MIME-Version: 1.0 In-Reply-To: <20190401130544.GA2628@chai> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Konstantin Osipov Separate patch would ruin the git history. I would rather fix this and box.sql.execute removal patchsets to keep the history clean. On 01/04/2019 16:05, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/04/01 11:45]: >> >> >> On 01/04/2019 08:21, Konstantin Osipov wrote: >>> * imeevma@tarantool.org [19/03/30 16:50]: >>>> This patch defines parameters binding for SQL statements executed >>>> through box.execute(). >>> >>> Could the dependency on lua_* be moved into src/box/lua/ or that >>> would be difficult to do? >> >> It requires exposure of struct sql_bind into the header file, and >> include "execute.h" into one of box/lua files. If you insist, we >> can do that. Should we? > > Yes, in a separate patch. > > > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >