From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 3/6] sql: remove SQL built-in functions from _func
Date: Fri, 6 Aug 2021 00:17:01 +0200 [thread overview]
Message-ID: <056fc01d-70ca-8f5a-85ab-6c85e68b3d06@tarantool.org> (raw)
In-Reply-To: <cd575f0326c6276a0b44470532acff22eb97f694.1628081224.git.imeevma@gmail.com>
Thanks for the patch!
> diff --git a/changelogs/unreleased/gh-6106-remove-sql-built-ins-from-_func.md b/changelogs/unreleased/gh-6106-remove-sql-built-ins-from-_func.md
> new file mode 100644
> index 000000000..88b458540
> --- /dev/null
> +++ b/changelogs/unreleased/gh-6106-remove-sql-built-ins-from-_func.md
> @@ -0,0 +1,7 @@
> +## feature/sql
> +
> +* SQL built-in functions were removed from \_func system space (gh-6106).
> +* After this patch, functions will be looked up first in SQL built-in functions
> + and then in user-defined functions.
1. In the changelog you shouldn't talk about 'this patch'. Maybe
about the release. But even better - just say 'Function are now lookeup ...'.
The users won't care about patches anyway.
> +* Fixed incorrect error message in case of misuse of the function used to set
> + the default value.
> \ No newline at end of file
2. Please, add an empty line at the end of the file.
next prev parent reply other threads:[~2021-08-05 22:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 12:58 [Tarantool-patches] [PATCH v2 0/6] Remove " Mergen Imeev via Tarantool-patches
2021-08-04 12:58 ` [Tarantool-patches] [PATCH v2 1/6] sql: introduce sql_func_flags() Mergen Imeev via Tarantool-patches
2021-08-05 22:14 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-06 19:41 ` Mergen Imeev via Tarantool-patches
2021-08-04 12:58 ` [Tarantool-patches] [PATCH v2 2/6] sql: introduce sql_func_find() Mergen Imeev via Tarantool-patches
2021-08-05 22:15 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-06 19:42 ` Mergen Imeev via Tarantool-patches
2021-08-04 12:58 ` [Tarantool-patches] [PATCH v2 3/6] sql: remove SQL built-in functions from _func Mergen Imeev via Tarantool-patches
2021-08-05 22:17 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-08-06 19:45 ` Mergen Imeev via Tarantool-patches
2021-08-04 12:58 ` [Tarantool-patches] [PATCH v2 4/6] alter: parse data dictionary version Mergen Imeev via Tarantool-patches
2021-08-05 22:17 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-06 19:47 ` Mergen Imeev via Tarantool-patches
2021-08-04 12:58 ` [Tarantool-patches] [PATCH v2 5/6] alter: disallow creation of SQL built-in function Mergen Imeev via Tarantool-patches
2021-08-05 22:18 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-06 19:54 ` Mergen Imeev via Tarantool-patches
2021-08-04 12:58 ` [Tarantool-patches] [PATCH v2 6/6] sql: remove unnecessary function initialization Mergen Imeev via Tarantool-patches
2021-08-06 19:59 ` Mergen Imeev via Tarantool-patches
2021-08-08 12:08 ` [Tarantool-patches] [PATCH v2 0/6] Remove SQL built-in functions from _func Vladislav Shpilevoy via Tarantool-patches
2021-08-09 7:18 Mergen Imeev via Tarantool-patches
2021-08-09 7:18 ` [Tarantool-patches] [PATCH v2 3/6] sql: remove " Mergen Imeev via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=056fc01d-70ca-8f5a-85ab-6c85e68b3d06@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 3/6] sql: remove SQL built-in functions from _func' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox