From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 51077430407 for ; Wed, 19 Aug 2020 23:37:32 +0300 (MSK) From: Vladislav Shpilevoy References: <20200817133918.875558-1-gorcunov@gmail.com> <20200817133918.875558-7-gorcunov@gmail.com> <4f76adf1-3185-d4e2-3a88-8d312c9e5951@tarantool.org> <20200817221403.GL2074@grain> Message-ID: <052d70b3-a11c-05db-15e7-87bd1b86ba19@tarantool.org> Date: Wed, 19 Aug 2020 22:37:30 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v8 6/9] applier: add shorthands to queue access List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov Cc: tml Hi! Today you said you did all the review fixes. I see that the branch didn't change, and this comment is still not addressed. On 18.08.2020 21:18, Vladislav Shpilevoy wrote: > On 18.08.2020 00:14, Cyrill Gorcunov wrote: >> On Mon, Aug 17, 2020 at 10:49:23PM +0200, Vladislav Shpilevoy wrote: >>> It seems this commit is not needed - I dropped it and nothing changed. >>> Even no merge/rebase conflicts. >>> >>> On 17.08.2020 15:39, Cyrill Gorcunov wrote: >>>> We need to access first and last xrow in a queue >>>> frenquently and opencoded variants are too ugly. >>> >>> frenquently -> frequently. >> >> The code is ugly as hell without it :/ > > There are many ugly things, but it does not mean we need to rush > changing them. It was discussed already many times. Please, drop > this commit. It is not necessary. It does not interfere with the > other patches in a single line.