From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 80D7F741E9; Fri, 6 Aug 2021 03:13:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 80D7F741E9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628208814; bh=hyLAFjuH/3VTEf1S+1XmBgTGt4xbIXDPQ/BwGV5/Ss8=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=skhf4cvqD3tsTWGipyssamEoCWl9SrnHme7jOZLkZmMuqkc0rAXP20VEi3nEl7VE1 bU4fL8Kcuhy8RirBSNW2D5+r/dPz8V8VCINmDtTnTg/4M6BIv9bYuFSIlgZKhgK3fL +B8dQn/7YNbjicp6M1IncVrEcJSb0MjMbK6vV2kc= Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E1260741E8 for ; Fri, 6 Aug 2021 03:13:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E1260741E8 Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1mBnUT-0007DP-6u; Fri, 06 Aug 2021 03:13:33 +0300 To: Mergen Imeev Cc: tarantool-patches@dev.tarantool.org References: <677f2d9facc0433219b12ca0b523a0691d1a39a1.1627504973.git.imeevma@gmail.com> <33c61d8c-1b92-1a57-247d-4cb3ade3103a@tarantool.org> <20210805233339.GB81912@tarantool.org> Message-ID: <04f59078-e7bd-56f7-5999-3080b54299f4@tarantool.org> Date: Fri, 6 Aug 2021 02:13:31 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210805233339.GB81912@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD972FF4A7D76DB5E242D14FEF1BD8BF4AC182A05F538085040377CCA02765195B2FF66E7FC424F6C8802F564F92868FBB123B9EA2810BDF112 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE706EA9E10470DC775EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D7F1BE85E7B0CA818638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8763F49C2CDDF910D8861633638BB7FEC117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE7B96B19DC40933214AAC223A686B1DECD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE389DDFE3E282F3DD16136E347CC761E07C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79D94463893BF8742D0CF34F2BAF9C410BB X-C1DE0DAB: 0D63561A33F958A5B54FF937BE6D4A95C33BAE6590A732200F2C97E8CCF9E2EDD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3438212F20E1E78D8E190507FB78E991C8CE2C2ECFD74756B4233D5BF0D0D4F5B6989F0D734B6278FA1D7E09C32AA3244C29B6F9F3FAD8C8E6C34C78ABCDA085688A6D4CC6FBFAC251729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFhlvmGwdUwQBdC/NQOuEHQ== X-Mailru-Sender: 1F3202E75A95DDEFC23907419AE0C7D763085A98BD5F35632BF798AEF098743D5E6D74ED9B01F55A07784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 2/7] sql: remove implicit cast from comparison opcodes X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" >>> diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c >>> index d143ce364..62f58def9 100644 >>> --- a/src/box/sql/vdbe.c >>> +++ b/src/box/sql/vdbe.c >> <...> >> >>> - switch( pOp->opcode) { >>> - case OP_Eq: res2 = res==0; break; >>> - case OP_Ne: res2 = res; break; >>> - case OP_Lt: res2 = res<0; break; >>> - case OP_Le: res2 = res<=0; break; >>> - case OP_Gt: res2 = res>0; break; >>> - default: res2 = res>=0; break; >>> + bool result; >>> + switch(pOp->opcode) { >> >> 3. It does not look good to have a second switch-case here. But I >> can't find a better solution right away. We can't wrap this all >> into a function, because need to make goto abort_due_to_error and >> goto jump_to_p2 in some places. Up to you if you want to find a >> way to fix it. >> >> As a side note, the code now is incomparably simpler than it was. >> It is getting actually understable, nice. >> > I divided these 6 opcode to two grops: EQ & NE and all others. ALso, I actually > can avoid branching in any groups using somethins like: > > int op = pOp->opcode; > bool result = (op == OP_Lt && cmp_res < 0) || (op == OP_Gt && cmp_res > 0) || ... > But not sure that it will be easier to read. What do you think? That is still branching - && and || are not better than 'if' usually. Up to you.