Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1] test: flaky engine/json.test.lua test
Date: Tue, 10 Nov 2020 16:46:26 +0300	[thread overview]
Message-ID: <04bd8d7d3201ec7db25af37d601f026c8719092c.1605015930.git.avtikhon@tarantool.org> (raw)

Found issue:

  No output during 120 seconds. Will abort after 120 seconds without output. List of workers not reporting the status:
    - 001_engine [engine/json.test.lua, memtx] at var/001_engine/json.result:598
  Test hung! Result content mismatch:
  --- engine/json.result	Fri Nov  6 08:35:45 2020
  +++ var/001_engine/json.result	Mon Nov  9 03:48:40 2020
  @@ -596,248 +596,3 @@
   - ok
   ...
   test_run:cmd("restart server default")
  -engine = test_run:get_cfg('engine')
  ----
  -…

It happened because test-run used to restart 'tarantoolctl restart'
routine with default signal SIGTERM. After tarantoolctl updated with
the ability to provide needed signal to kill the instance, then SIGKILL
was set in the test.

Part of #5510
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5510-hang-test-json
Issue: https://github.com/tarantool/tarantool/issues/5510

 test/engine/json.result   | 2 +-
 test/engine/json.test.lua | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/engine/json.result b/test/engine/json.result
index b8fd9a1b6..0780c39b7 100644
--- a/test/engine/json.result
+++ b/test/engine/json.result
@@ -595,7 +595,7 @@ box.snapshot()
 ---
 - ok
 ...
-test_run:cmd("restart server default")
+test_run:cmd("restart server default with signal=KILL")
 engine = test_run:get_cfg('engine')
 ---
 ...
diff --git a/test/engine/json.test.lua b/test/engine/json.test.lua
index 371bbad91..427f14c36 100644
--- a/test/engine/json.test.lua
+++ b/test/engine/json.test.lua
@@ -170,7 +170,7 @@ name:select({})
 name:select({'Max'})
 name:get({'Max', 'Stierlitz', 'Otto'})
 box.snapshot()
-test_run:cmd("restart server default")
+test_run:cmd("restart server default with signal=KILL")
 engine = test_run:get_cfg('engine')
 s = box.space["withdata"]
 pk = s.index["pk"]
-- 
2.25.1

                 reply	other threads:[~2020-11-10 13:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04bd8d7d3201ec7db25af37d601f026c8719092c.1605015930.git.avtikhon@tarantool.org \
    --to=avtikhon@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1] test: flaky engine/json.test.lua test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox