From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alyapunov@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3EF07445320
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 15 Jul 2020 10:57:14 +0300 (MSK)
References: <1594221263-6228-1-git-send-email-alyapunov@tarantool.org>
 <1594221263-6228-12-git-send-email-alyapunov@tarantool.org>
 <198d4c8b-0e6b-9cd0-1d80-8d40f6c68081@tarantool.org>
From: Aleksandr Lyapunov <alyapunov@tarantool.org>
Message-ID: <04ba69b3-e1fd-1435-4868-539b66a55450@tarantool.org>
Date: Wed, 15 Jul 2020 10:57:12 +0300
MIME-Version: 1.0
In-Reply-To: <198d4c8b-0e6b-9cd0-1d80-8d40f6c68081@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH 11/16] tx: introduce conflict tracker
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org

On 15.07.2020 02:51, Vladislav Shpilevoy wrote:
>
>> +	tracker->wreaker = wreaker;
>> +	tracker->victim = victim;
> Why don't you save anything into the victim? How will it be
> removed from the lists if it will commit earlier than 'wreaker'?
>
Good catch, it's a bug.
I have actually found it by myself and fixed it, but thanks nevertheless.