From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 07E21469719 for ; Wed, 12 Feb 2020 01:17:23 +0300 (MSK) References: <0a6143594e0279d19d3b760a75f0139dbd42dae8.1580841722.git.korablev@tarantool.org> <20200211141427.GC5168@tarantool.org> From: Vladislav Shpilevoy Message-ID: <04b6832e-212e-a323-63bf-962b35196f12@tarantool.org> Date: Tue, 11 Feb 2020 23:17:21 +0100 MIME-Version: 1.0 In-Reply-To: <20200211141427.GC5168@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 2/4] sql: refactor sqlVdbeMemNumerify() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org Hi! Thanks for the fixes! I've pushed my review fixes on top of this commit. See it in the end of the email, and on the branch. I aligned the comment by 66 symbols, and changed '@mem' to '@a mem' in a second place. Talking of your questions - why do we use @a? I think just because it was needed to choose something and @a was chosen. From what I remember, doxygen does not have a special command for mentioning function parameters inside function's description. So there was no a standard way. ================================================================================ commit bde8e58b05c5e4d3c650eea10e5905ce228b943d Author: Vladislav Shpilevoy Date: Tue Feb 11 23:07:36 2020 +0100 Review fixes diff --git a/src/box/sql/vdbeInt.h b/src/box/sql/vdbeInt.h index 9ecf7a486..38305ce1d 100644 --- a/src/box/sql/vdbeInt.h +++ b/src/box/sql/vdbeInt.h @@ -535,11 +535,12 @@ int mem_apply_integer_type(Mem *); int sqlVdbeMemRealify(Mem *); /** - * Convert @a mem to NUMBER type, so that after conversion it has one - * of types MEM_Real, MEM_Int or MEM_UInt. If conversion is not possible, - * function returns -1. + * Convert @a mem to NUMBER type, so that after conversion it has + * one of types MEM_Real, MEM_Int or MEM_UInt. If conversion is + * not possible, function returns -1. * - * Beware - this function changes value and type of @mem argument + * Beware - this function changes value and type of @a mem + * argument. */ int vdbe_mem_numerify(struct Mem *mem);