From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 689136EC55; Sat, 31 Jul 2021 12:22:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 689136EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627723362; bh=84BRQuWZk8nt8ClU67c1pXyI0e+NkevXgiJsO9IJju8=; h=To:References:In-Reply-To:Date:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DKmkPGeQMAXnoagqsaB9q0Ugus+uq/ash6Dq/Unjp1rBoU4c8ErYCIraAvP6KbWkr b0bMjv5sxDG6y9/DZp58CKksxfweMJes8DaJfgMoVLpHhQlrvJhUbpVCShCHa5V5Sl vf+Ki2UGtIL3dOvKWK4dkaAk6BttERThuUhNbK6A= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 390A36EC55 for ; Sat, 31 Jul 2021 12:22:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 390A36EC55 Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1m9lCa-0005Xx-98; Sat, 31 Jul 2021 12:22:40 +0300 To: "'Vladislav Shpilevoy'" References: <95f9a0a7-e539-f381-aef7-9dd74c50e03e@tarantool.org> In-Reply-To: <95f9a0a7-e539-f381-aef7-9dd74c50e03e@tarantool.org> Date: Sat, 31 Jul 2021 12:22:39 +0300 Message-ID: <048001d785ed$9c044d70$d40ce850$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQNJI0ot4YBfKbZyj2tYNprdOv6c+gLKCqQSAgtoJVSoUS9yIA== Content-Language: ru X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B20CA14D9DFB46B94A182A05F53808504002014DCB962AFAB77379236E798FB70E66B866743A0FFE54F0068EF47541E200 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7978947DCA0D4215FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375E280A1EC162AD7D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C3B9831A4AC558DED336AABA6E38F423117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEC65AC60A1F0286FEFCE65BE3358055BDD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE313BDA61BF53F5E1D03F1AB874ED89028C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BBEA499411984DA1EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79DB53CE843736870893854ACD9C837D8C8 X-C1DE0DAB: 0D63561A33F958A566EAB742910EEFB8E50419EE042609C1A69821C87C3604A6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA751B940EDA0DFB0535410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344A2E3AE0A8792E69C019DB4D868754C0553D87AF7FA4F91A063923C377992549B441E58E12542F131D7E09C32AA3244CD2107B19A396AE8C39464F7DD64A0E473C6EB905E3A8056B927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNLQ8Cqcv1itKEu4dWu6uzA== X-Mailru-Sender: B5B6A6EBBD94DAD886B83A8C3338640666A8747A1C751D80EFBD686B187B80B0F45F66086E47414C1EC9E4A2C82A33BC8C24925A86E657CE0C70AEE3C9A96FBAB3D7EE8ED63280BE112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH resend v2 01/11] build: add Christian Hansen c-dt to the build X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Timur Safin via Tarantool-patches Reply-To: Timur Safin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" : From: Vladislav Shpilevoy : Subject: Re: [PATCH resend v2 01/11] build: add Christian Hansen c-dt = to the : build :=20 : Hi! Thanks for the patch! :=20 : On 28.07.2021 12:34, Timur Safin wrote: : > * Integrated chansen/c-dt parser as 3rd party module to the : > Tarantool cmake build process. : > * Points to tsafin/c-dt instead iof original chansen/c-dt to :=20 : iof -> of. But is it even true? Below I see Thanks! :=20 : url =3D https://github.com/tarantool/c-dt.git :=20 : not tsafin/c-dt. We have relocated repository to Tarantool organization since then. :=20 : After build I get in git status this: :=20 : Changes not staged for commit: : (use "git add ..." to update what will be committed) : (use "git restore ..." to discard changes in working : directory) : (commit or discard the untracked or modified content in submodules) : modified: third_party/c-dt (modified content, untracked : content) :=20 : It says: :=20 : modified: Makefile :=20 : and some untracked files: :=20 : CMakeFiles/ : cmake_install.cmake : libcdt.a :=20 : Why is even Makefile added to the repository if we are : using cmake anyway? Yeah, sounds like a small cmake configuration annoyance. Cmake here = generates their=20 artifacts just right under sources, and not under = ${CMAKE_CURRENT_BINARY_DIR}. Will look how we could improve things, making it cleaner.=20 Thanks, Timur