From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 136A47030C; Tue, 9 Feb 2021 12:36:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 136A47030C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1612863372; bh=uown2mzeRdcF3JHPJ1vmY/TFscqDIEOd8RHQuzawTPE=; h=To:Cc:References:In-Reply-To:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=wNWdBKR+UAZdHzYPDn11ZuEmdC6VJLRtD+iSy9Ys+MtWYo7gHJ+aR4wx8Wt2k/PK4 ruZpsf+GcXiMj60IZsbAAPLgTylb+/74gU88G3uaO8B7L/sdfvPJlAd1/RVuvW3kB9 TZb1vaDv6OUP8nxpgLqFQN+wQF0wtUK1SIdZv8Z8= Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8A4C77030C for ; Tue, 9 Feb 2021 12:36:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8A4C77030C Received: by smtp45.i.mail.ru with esmtpa (envelope-from ) id 1l9PRF-0007Mh-Sn; Tue, 09 Feb 2021 12:36:06 +0300 To: , Cc: References: In-Reply-To: Date: Tue, 9 Feb 2021 12:36:03 +0300 Message-ID: <047b01d6fec6$fbbb8ac0$f332a040$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQH3nDARfbN/F+LiiguWA82wgsoPP6oOVCvQ Content-Language: ru X-618D5548: BE3B04195E12B6CB3E041A2D5B608D556F902AA30F69CAF1D8716A5C7208951B X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9CAEF2BF42A2A7729330F8028A4C0D8125182A05F538085040662FCF3B1DC123B2737CDD86EF35261594C16A9C11881878CAB4E1691EAEFEC6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75AD53DF1D86BACA3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BA5555A0C16230F4EA1F7E6F0F101C674E70A05D1297E1BBC6CDE5D1141D2B1C66E5586B7F36E4D6639E32CEF13E4978E42BAA3558445C609FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B3A703B70628EAD7BA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCE7CF831D07CEC04ED81D268191BDAD3DBD4B6F7A4D31EC0BEA7A3FFF5B025636D81D268191BDAD3D78DA827A17800CE7BB3912DD6E90BF6CEC76A7562686271EEC990983EF5C032935872C767BF85DA29E625A9149C048EE1B544F03EFBC4D57DC7F9DB2523BC7CD4AD6D5ED66289B524E70A05D1297E1BB35872C767BF85DA227C277FBC8AE2E8B3241B8C6B78F28F975ECD9A6C639B01B4E70A05D1297E1BBC6867C52282FAC85D9B7C4F32B44FF57C2F2A386D11C4599BD9CCCA9EDD067B1EDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A59FF4D276B5D7383CBC2B06ABE4AA5884EECF3BE2E7CFA974D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349320586B19AD2C725FAF8BB484BB99944A324E1510D8CB1828374F3362C2E6D0454C7D98E9A848711D7E09C32AA3244C4BDEAC26972A18F61C07D47A695EACAC4DBEAD0ED6C55A80FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojg67HQLCbniLqVGlvwls7bA== X-Mailru-Sender: 6CA451E36783D721CBEA96CEA26D325DBE3B04195E12B6CB3E041A2D5B608D55B7CBEF92542CD7C82F97C478340294DCC77752E0C033A69E0F0C7111264B8915FF1320A92A5534336C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 00/10] Encapsulate MEM type changing and checking X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Timur Safin via Tarantool-patches Reply-To: Timur Safin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for this refactoring attempt, but could you (please, please)=20 make it (somehow magically) easier to review? I mean the part where we extract something from here, wrap I as a function, and replace with that function call ideally would be to put to the same patch - for better observability. So we make it more visible that functionality remains intact? I know that is tricky in git, but possible after some massaging. (May=20 Be simply squash it to the single patch as a first approach?) I've no much complains yet about particular cases - but there is=20 some objection about newly introduced static_alloc, please see in=20 other message. Regards, Timur : From: imeevma@tarantool.org : Subject: [PATCH v1 00/10] Encapsulate MEM type changing and checking :=20 : This patch-set encapsulates type changing and checking for MEM. This = is done : to : make easier for us to introduce new rules for implicit and explicit = type : casting : and new types in SQL. :=20 : https://github.com/tarantool/tarantool/issues/4470 : = https://github.com/tarantool/tarantool/tree/imeevma/gh-4470-encapsule-typ= e- : setting-v3 :=20 :=20 : Mergen Imeev (10): : sql: introduce mem_set_*() functions : sql: Initialize MEM in sqlVdbeAllocUnpackedRecord() : sql: introduce mem_is_*() functions : sql: introduce mem_convert_to_binary() : sql: refactor vdbesort.c : sql: refactor sql/func.c : sql: refactor vdbetrace.c : sql: refactor vdbeapi.c : sql: refactor vdbeaux.c : sql: refactor vdbe.c :=20 : src/box/sql/func.c | 2 +- : src/box/sql/vdbe.c | 453 = ++++++++++++++++++---------------------- : src/box/sql/vdbeInt.h | 204 ++++++++++++++++++ : src/box/sql/vdbeapi.c | 53 ++--- : src/box/sql/vdbeaux.c | 268 +++++++++++------------- : src/box/sql/vdbemem.c | 116 ++++++++++ : src/box/sql/vdbesort.c | 9 +- : src/box/sql/vdbetrace.c | 12 +- : 8 files changed, 674 insertions(+), 443 deletions(-) :=20 : -- : 2.25.1