From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E112D2DAB1 for ; Tue, 11 Jun 2019 17:11:30 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ghD634nuAXBQ for ; Tue, 11 Jun 2019 17:11:30 -0400 (EDT) Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E523D2D9DA for ; Tue, 11 Jun 2019 17:11:29 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 5/6] sql: introduce extended range for INTEGER type References: From: Vladislav Shpilevoy Message-ID: <047750c3-04ab-0805-944e-c5afd5781aa8@tarantool.org> Date: Tue, 11 Jun 2019 23:11:40 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Nikita Pettik Thanks for the patch! See 1 comment below, review fixes at the end of the email, and on the branch in a separate commit. > diff --git a/src/box/errcode.h b/src/box/errcode.h > index f4aba2f54..417029adb 100644 > --- a/src/box/errcode.h > +++ b/src/box/errcode.h > @@ -242,7 +242,7 @@ struct errcode_record { > /*187 */_(ER_SQL_ANALYZE_ARGUMENT, "ANALYZE statement argument %s is not a base table") \ > /*188 */_(ER_SQL_COLUMN_COUNT_MAX, "Failed to create space '%s': space column count %d exceeds the limit (%d)") \ > /*189 */_(ER_HEX_LITERAL_MAX, "Hex literal %s%s length %d exceeds the supported limit (%d)") \ > - /*190 */_(ER_INT_LITERAL_MAX, "Integer literal %s exceeds the supported range %lld - %lld") \ > + /*190 */_(ER_INT_LITERAL_MAX, "Integer literal %s exceeds the supported range %lld - %llu") \ That error is used only once and with the constants. Please, inline them, and make that error argument-less. Also, alongside I propose you to write the range in [start, end] instead of 'start - end'. The latter looks like a minus. Please, consider my review fixes here and on the branch in a separate commit: ============================================================= diff --git a/src/box/sql/build.c b/src/box/sql/build.c index 75d6579ca..93aab8501 100644 --- a/src/box/sql/build.c +++ b/src/box/sql/build.c @@ -918,10 +918,10 @@ emitNewSysSequenceRecord(Parse *pParse, int reg_seq_id, const char *seq_name) /* 5. Minimum */ sqlVdbeAddOp4Dup8(v, OP_Int64, 0, first_col + 5, 0, - (unsigned char*)&min_usigned_long_long, P4_UINT64); + (unsigned char *) &min_usigned_long_long, P4_UINT64); /* 6. Maximum */ sqlVdbeAddOp4Dup8(v, OP_Int64, 0, first_col + 6, 0, - (unsigned char*)&max_usigned_long_long, P4_UINT64); + (unsigned char *) &max_usigned_long_long, P4_UINT64); /* 7. Start */ sqlVdbeAddOp2(v, OP_Integer, 1, first_col + 7);