From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5FE097030C; Tue, 9 Feb 2021 11:17:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5FE097030C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1612858625; bh=RoPZubCJnqTlTeaMYFI0J//yfm95ogn5vhZC/3Vl8gw=; h=To:References:In-Reply-To:Date:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=llRmHGT7bT00viGUmxULno2SzjooG7RnU/E0Wp1I9pz4DBN4TM371ZCBeAzw1bLGl 2GE+VfrARkMo+u5hZ84+cABMvXTGatLrkLxGA56fRyqj6cnh5j35WmbfDVbz0q9slY VjvCwPcw+CRwRXgqQOb02OdyaIVED6+DBv2yZ16U= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 64CD27030C for ; Tue, 9 Feb 2021 11:17:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 64CD27030C Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1l9OCi-0005bs-6z; Tue, 09 Feb 2021 11:17:00 +0300 To: "'Igor Munkin'" References: <6a03d693204cacc5791c75e1003efc150abb2979.1612291495.git.imun@tarantool.org> <01d401d6fe2b$dd80c160$98824420$@tarantool.org> <20210208162930.GF5448@tarantool.org> In-Reply-To: <20210208162930.GF5448@tarantool.org> Date: Tue, 9 Feb 2021 11:16:57 +0300 Message-ID: <044301d6febb$ef1af8b0$cd50ea10$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJPfenCWrjRxS0krGRZARdqgOlJ3gIL945VAa2c2BwBg+GQK6k0j/hg Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9C4647521586BE7E637AB8B70F7375365A182A05F5380850409C0700C148A7B7E8AE1595F22E608E21C98A5434EB889ABEE9F04DC7A653F8C6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B7733D0215A2F71AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063715F166F2542EEE4C8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCDB9C9A7D0C39A115412D9863623914CD1CFDE19F35A780F1389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C224996A66781A01B7C2E76E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8BBC8CE19D55AF3C103AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE79BDF008AB5706B4967F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C37C6C241D9975906435872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C920A5816FF58DF6CF574AF45C6390F7469DAA53EE0834AAEE X-B7AD71C0: 14C14B24D00AF5AC321EF223B8115265C69B993890792DF82CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46D2A1573CCDD057E4E355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A544803A8B0BF7439DE1187F7D73D7B99F5E0452B45B151D5DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C75F910DBB8BE8986DF6C09E27565AA19BBDFF68EDCC33FDA5428F2E5C119C67754C48243BF2B4541D7E09C32AA3244C2E3E15702CEDA98CE0D82A1F9A52E0838580396430872480FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojg67HQLCbniKaXzFjZ0Mdng== X-Mailru-Sender: 6CA451E36783D721CBEA96CEA26D325DF7A47E78BFF9AA5CF4A6C2BD39936A50B7CBEF92542CD7C82F97C478340294DCC77752E0C033A69E0F0C7111264B8915FF1320A92A5534336C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/5] test: run LuaJIT tests via CMake X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Timur Safin via Tarantool-patches Reply-To: Timur Safin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" : From: Igor Munkin : Subject: Re: [PATCH luajit 3/5] test: run LuaJIT tests via CMake : : Timur, : : Thanks for your review! : : > : > I don't like this. It reminds me of bad examples of this note : > in the libev code like "this is so uncontrollably lame" which : > actually distract users. We should rather put comments in more : > neutral way (IMVHO). : : Unfortunately... CMake is a crap and I can't fix it. Well, honestly I : don't want to fix it. But you're right: I can fix all these comments : (athough I don't really want to). I have no idea how to express this in : a more neutral way, so I propose the following: : 1. s/CMake is a crap/there is no convenient way to make it in CMake/g. : 2. Leave everything else unchanged. Hmm, ok. : : This is not only emotions. Such comments prevent one from unintentional : refactoring of such fragile places with no failures and also from : bothering the oldies with the questions kinda "dude, why is this done so : badly". In other words, primarily I have left this for the history. : : If you're OK, then I'll fix the way described above. : : > : > : + # Add the directory where the lib is built to the LUA_CPATH : > : + # environment variable, so interpreter can find and load it. : > : + # XXX: Here we see the other side of the coin. If one joins two : > : + # strings with semicolon, the value automatically becomes the : > : + # list. I have no idea what is wrong with this tool, but I found : > : + # a single working solution to make LUA_CPATH be a string via : > : + # "escaping" the semicolon right in string interpolation. : > : + set(LUA_CPATH : > : : "${CMAKE_CURRENT_BINARY_DIR}/?${CMAKE_SHARED_LIBRARY_SUFFIX}\;${LUA_CPATH}" : > : PARENT_SCOPE) : > : + # Also add this directory to LD_LIBRARY_PATH environment : > : + # variable, so FFI machinery can find and load it. : > : + set(LD_LIBRARY_PATH "${CMAKE_CURRENT_BINARY_DIR}:${LD_LIBRARY_PATH}" : > : PARENT_SCOPE) : > : +endmacro() : > : + : > : +add_subdirectory(gh-4427-ffi-sandwich) : > : +add_subdirectory(lj-flush-on-trace) : > : +add_subdirectory(misclib-getmetrics-capi) : > : > I liked you introduced globs for test files addition (blow), : > but unfortunately you didn't complete this with subdirectory addition : : I have thought about it for some time, and I have a strong rationale (at : least for me) to not introducing such change: this doesn't work whether : there are directories inside containing no tests. Furthermore, we're : going to re-implement several C tests, so I would like to leave : everything as it is (if you don't mind) and return to this place later. Ok, if you plan to refactor it, because today it looks inconsistent a bit. : : > : > Please see my proposed patch (with reworded comments and new macro) here : https://gist.github.com/tsafin/6c7505c0c764ab2b474667bf0d65fb45. : > : : : : > : > Regards, : > Timur : > : : -- : Best regards, : IM Regards, Timur