From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8D38C24279 for ; Mon, 2 Jul 2018 13:58:46 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dXZA6Z614P-S for ; Mon, 2 Jul 2018 13:58:46 -0400 (EDT) Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E171624227 for ; Mon, 2 Jul 2018 13:58:45 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 1/1] sql: disallow returning many rows from subselect References: <7815ec2cb5cfb0d837478cff88fe4ba95503e8d7.1530113937.git.kshcherbatov@tarantool.org> <80d9fc88-3030-764b-55f2-86d6e5e33f03@tarantool.org> <411BF67B-D49B-468C-80EF-AF31D520F0DF@tarantool.org> <7ba69010-2e21-9e4f-d923-4061ddecf4cf@tarantool.org> <1ea436b1-2471-2b8a-8223-c12095308994@tarantool.org> <93dc0283-244c-8ea6-46bc-10e616be1810@tarantool.org> From: Vladislav Shpilevoy Message-ID: <04110c81-7bdc-5699-3a76-642309e9b5ad@tarantool.org> Date: Mon, 2 Jul 2018 20:58:42 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org Thanks for the fixes! LGTM. On 02/07/2018 17:52, Kirill Shcherbatov wrote: >> SQL_TARANTOOL_ERROR is not error code. See errcode.h. The previous >> hunk is correct. > Hm, I've forgot update this piece of patch in mail. > There is no such mistake on branch already. >