From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5C25370202; Wed, 24 Feb 2021 10:16:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5C25370202 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614150999; bh=+iq3ch7YrR6yHoiHFa0XGFZtHDnsFN/3EGgefhLav6g=; h=To:Cc:References:In-Reply-To:Date:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=aFEBtatk/h8V+cUVxbU+RiFHNvPSCGQFFv0RNQovEihPy51MdbK34T9dn1gdoHc1i MBiuXUDyX4Pbice4FAR79/rALz0d7JbfdEDCqHND+mRF9Nnqh8yujZwR8CnFOejZy3 DWkCDslBISRsHjM/nMRVNINXBK0yzoxopHX6GQUk= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0EEEC70202 for ; Wed, 24 Feb 2021 10:16:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0EEEC70202 Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1lEoPU-0002Pq-NE; Wed, 24 Feb 2021 10:16:37 +0300 To: "'Igor Munkin'" , "'Sergey Kaplun'" , "'Alexander V. Tikhonov'" Cc: "TML" References: <2ac28542e4eac2031e5c30b279aabd3bcacbd7a1.1612390822.git.imun@tarantool.org> In-Reply-To: <2ac28542e4eac2031e5c30b279aabd3bcacbd7a1.1612390822.git.imun@tarantool.org> Date: Wed, 24 Feb 2021 10:16:29 +0300 Message-ID: <03e801d70a7c$f9162700$eb427500$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKSGo9nMqUfEa7rxZOpsUP/wg+emgE/yriaqObDutA= Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD975C3EC174F566922928A658C60196E87DF7449A63D990329182A05F5380850402E97E1075D6A694061FA900CA97CB2F0E2FE8D7FA47E99BE9214AE7D4159BB08 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74B7EDB5828CF9C27EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374FA524FBD8B89EAA8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCBF5079162FBBBC41C768EBFE14FEB7E19DB639AF07EA17B4389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249D4C4ECAC619A54F376E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B0FC4FCDDD36A1EE6D81D268191BDAD3D698AB9A7B718F8C442539A7722CA490C13377AFFFEAFD26923F8577A6DFFEA7CE31A2885C41F97C493EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B6753C3A5E0A5AB5B7089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E702188758A277F09663E5BFE6E7EFDEDCD789D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46D94C59F50E339E346355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A5D1A2B71E41C626D4CF54AD7ECDDED3FE568B435F7518BAADD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75B7BFB303F1C7DB4D8E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348B532EA2091F4FF611B35690C617D4DB3571F95CCB71BF506073491D305722E3966C7688A2CD16AD1D7E09C32AA3244CFA5822023F7819E37417896048DBCB9FF522A1CF68F4BE05927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojyK6JYJ15DtJY+0/lfXVo7g== X-Mailru-Sender: 6CA451E36783D721CBEA96CEA26D325D0A81B93249DFB121EFE86023FD86D9EEB7CBEF92542CD7C82F97C478340294DCC77752E0C033A69E0F0C7111264B8915FF1320A92A5534336C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Timur Safin via Tarantool-patches Reply-To: Timur Safin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This 1 thing is the only one that is bother me: it looks dependency of Tarantool LuaJIT tests are not yet properly assigned between build=20 Targets we have. Let me put it how it looks like from my side: - LuaJIT-test is phony, defined in third_party/luajit target and=20 depends on tarantool-tests=20 - tarantool-tests are not phony (i.e. you could not run Tarantool-tests=20 Twice, if you wish to) - third_party/luajit/test is also depending on LuaJIT-luacheck Which is not phone either, and is not runnable if you Run it outside of Tarantool build (because .luacheckrc is=20 At the root of Tarantool repo, not LuaJIT repo). - Also LuaJIT-test is explicitly referred in the travis makefiles And not implicitly called by dependency of Tarantool testing. This bothers me a lot, looks like dependency tree is not working correctly at the moment. Could you please make luacheck and = Tarantool-test targets phony, and add LuaJIT-test as prerequisite of Tarantool testing (in cmake)? Thanks, Timur : -----Original Message----- : From: Tarantool-patches = On : Behalf Of Igor Munkin via Tarantool-patches : Sent: Thursday, February 4, 2021 2:22 AM : To: Sergey Kaplun ; Alexander V. Tikhonov : : Cc: tarantool-patches@dev.tarantool.org : Subject: [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI :=20 : This patch adds LuaJIT tests to every CI job type except the one for : static build testing routine on OSX: there is no way to run LuaJIT = tests : for out of source build on OSX due to SIP[1]. :=20 : [1]: : = https://developer.apple.com/library/archive/documentation/Security/Concep= tua : = l/System_Integrity_Protection_Guide/FileSystemProtections/FileSystemProte= cti : ons.html :=20 : Follows up #4862 :=20 : Signed-off-by: Igor Munkin : --- : .travis.mk | 20 ++++++++++++++++++++ : 1 file changed, 20 insertions(+) :=20 : diff --git a/.travis.mk b/.travis.mk : index 50524007c..c2b79a4e5 100644 : --- a/.travis.mk : +++ b/.travis.mk : @@ -134,6 +134,7 @@ build_debian: configure_debian :=20 : test_debian_no_deps: build_debian : cd test && /usr/bin/python test-run.py --force : $(TEST_RUN_EXTRA_PARAMS) : + make LuaJIT-test :=20 : test_debian: deps_debian test_debian_no_deps :=20 : @@ -148,6 +149,7 @@ build_coverage_debian: : test_coverage_debian_no_deps: build_coverage_debian : # Enable --long tests for coverage : cd test && /usr/bin/python test-run.py --force : $(TEST_RUN_EXTRA_PARAMS) --long : + make LuaJIT-test : lcov --compat-libtool --directory src/ --capture --output-file : coverage.info.tmp \ : --rc lcov_branch_coverage=3D1 --rc lcov_function_coverage=3D1 : lcov --compat-libtool --remove coverage.info.tmp 'tests/*' : 'third_party/*' '/usr/*' \ : @@ -213,6 +215,10 @@ test_asan_debian_no_deps: build_asan_debian : LSAN_OPTIONS=3Dsuppressions=3D${PWD}/asan/lsan.supp \ :=20 : = ASAN_OPTIONS=3Dheap_profile=3D0:unmap_shadow_on_exit=3D1:detect_invalid_p= oin : = ter_pairs=3D1:symbolize=3D1:detect_leaks=3D1:dump_instruction_bytes=3D1:p= rint_suppre : ssions=3D0 \ : ./test-run.py --force $(TEST_RUN_EXTRA_PARAMS) : + ASAN=3DON \ : + LSAN_OPTIONS=3Dsuppressions=3D${PWD}/asan/lsan.supp \ : + : = ASAN_OPTIONS=3Dheap_profile=3D0:unmap_shadow_on_exit=3D1:detect_invalid_p= oin : = ter_pairs=3D1:symbolize=3D1:detect_leaks=3D1:dump_instruction_bytes=3D1:p= rint_suppre : ssions=3D0 \ : + make LuaJIT-test :=20 : test_asan_debian: deps_debian deps_buster_clang_11 = test_asan_debian_no_deps :=20 : @@ -237,6 +243,7 @@ test_static_build_cmake_linux: : make -j && ctest -V : cd test && /usr/bin/python test-run.py --force \ : --builddir ${PWD}/static-build/tarantool-prefix/src/tarantool- : build $(TEST_RUN_EXTRA_PARAMS) : + make -C ${PWD}/static-build/tarantool-prefix/src/tarantool-build : LuaJIT-test :=20 : # ################### : # Static Analysis : @@ -274,6 +281,7 @@ test_oos_no_deps: build_oos : ${OOS_SRC_PATH}/test/test-run.py \ : --builddir ${OOS_BUILD_PATH} \ : --vardir ${OOS_BUILD_PATH}/test/var --force : + make -C ${OOS_BUILD_PATH} LuaJIT-test :=20 : test_oos: deps_debian test_oos_no_deps :=20 : @@ -339,6 +347,7 @@ INIT_TEST_ENV_OSX=3D\ : test_osx_no_deps: build_osx : ${INIT_TEST_ENV_OSX}; \ : cd test && ./test-run.py --vardir ${OSX_VARDIR} --force : $(TEST_RUN_EXTRA_PARAMS) : + make LuaJIT-test :=20 : test_osx: deps_osx test_osx_no_deps :=20 : @@ -362,6 +371,16 @@ test_static_build_cmake_osx: base_deps_osx : cd test && ./test-run.py --vardir ${OSX_VARDIR} \ : --builddir ${PWD}/static-build/tarantool-prefix/src/tarantool- : build \ : --force $(TEST_RUN_EXTRA_PARAMS) : + # FIXME: Hell with SIP on OSX: Tarantool (and also LuaJIT) : + # is built out of sources, so the test located in the : + # source directory fails to load the shared library built : + # in the binary directory via dlopen(3). : + # For more info proceed the link below: : + # : = https://developer.apple.com/library/archive/documentation/Security/Concep= tua : = l/System_Integrity_Protection_Guide/FileSystemProtections/FileSystemProte= cti : ons.html : + # Do not run LuaJIT related tests for this built until the : + # issue is not resolved. : + # : + # make -C ${PWD}/static-build/tarantool-prefix/src/tarantool-build : LuaJIT-test :=20 :=20 : ########### : @@ -378,6 +397,7 @@ build_freebsd: :=20 : test_freebsd_no_deps: build_freebsd : cd test && python2.7 test-run.py --force $(TEST_RUN_EXTRA_PARAMS) : + make LuaJIT-test :=20 : test_freebsd: deps_freebsd test_freebsd_no_deps :=20 : -- : 2.25.0