From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 66291445327 for ; Sun, 5 Jul 2020 20:05:12 +0300 (MSK) References: <1593757997-4145-1-git-send-email-alyapunov@tarantool.org> <1593757997-4145-8-git-send-email-alyapunov@tarantool.org> From: Vladislav Shpilevoy Message-ID: <03d9b057-ab79-9445-7a43-c3345a82e1e8@tarantool.org> Date: Sun, 5 Jul 2020 19:05:10 +0200 MIME-Version: 1.0 In-Reply-To: <1593757997-4145-8-git-send-email-alyapunov@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 07/15] tx: save preserve old tuple flag in txn_stmt List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aleksandr Lyapunov , tarantool-patches@dev.tarantool.org > diff --git a/src/box/txn.h b/src/box/txn.h > index 1394bfb..e860e1e 100644 > --- a/src/box/txn.h > +++ b/src/box/txn.h > @@ -129,6 +129,15 @@ struct txn_stmt { > struct xrow_header *row; > /** on_commit and/or on_rollback list is not empty. */ > bool has_triggers; > + /** > + * Whether the stmt upon commit must replace exactly old_tuple from it. > + * Explanation: to the moment of commit of the statement actual state > + * of the space could change due to commit of other transaction(s). > + * Some statements require the replaced tuple at the moment of commit to > + * be exactly the same as replaced tuple at the moment of execution. > + * Some - doesn't. > + */ I still can't understand why is this flag added. Can you provide an example? > + bool preserve_old_tuple; Flag names should be started from is/has/does/... . > /** Commit/rollback triggers associated with this statement. */ > struct rlist on_commit; > struct rlist on_rollback; >