From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C70FC6C7D2; Sat, 30 Jan 2021 22:17:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C70FC6C7D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1612034279; bh=mzob2OnI9iQeaKGL2/zEQ1wGdniwos1kQgzbcsnJGzM=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=IW+poifFTK1Q22a6hqOSHc9yICI9Y+xLRyzlxsjeLd+7jjB3kAayTjHfE4DO5Josl ITG3ewTRHPfCS4ucCDEhT9vUrKsSlHMLG7mm+IxaHEWDNqJqzOwFTemLrRun3jO/Bd oP9RAutHkAKafRTsRAkWoRKJmZj7jjAOqYVQGCcA= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1191E6C7D2 for ; Sat, 30 Jan 2021 22:17:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1191E6C7D2 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1l5vks-0003O1-HW; Sat, 30 Jan 2021 22:17:58 +0300 To: Cyrill Gorcunov , tml References: <20210122132700.272816-1-gorcunov@gmail.com> <20210122132700.272816-4-gorcunov@gmail.com> Message-ID: <03d851a9-d0c1-9db1-1a1e-61d474a10369@tarantool.org> Date: Sat, 30 Jan 2021 20:17:57 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210122132700.272816-4-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9CD238BCF93DF23716D1711D0DDC4F5AC2182A05F5380850407DC7634D43531F6A2BB11DBFC27F5CC0B7BCF7DECB40FF638BBE95D8E318BFC3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE722087ABFAC96EBFEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F222FE4DD9849F468638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCE311601C3C2B550F0FC0D97990546F012BFBD8EA2B690477389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0B27420F9988F54058941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6AEEA5BB16A939343CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC8785BF30A5E9335375ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E735BEFCD6C56BCFE9CEC4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F93F060FBA3C93C613B503F486389A921A5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E923155C0AF1600DCBC20B3818D0065596AF5AE3A9E4AC265E75B4 X-C1DE0DAB: 0D63561A33F958A532DD77CC1339C3D1954DB004106A597E40C5EDCB1F597DCAD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340297C696F996E38474F6AAC75883B2BC1575705F3FC80B907A3AE89E57557C75DB2B1D6A44E341FD1D7E09C32AA3244C431EAF7BF9EBD43443BFC882C957548FE646F07CC2D4F3D8729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBjC2XHTqRV234u1lbMOn1A== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382249052917A9793523E5C6377E151204003841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/6] test/unit: snap_quorum_delay -- stop using txn_set_flag X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! Ok, I assume it is fine to drop these functions one by one, even though it leaves the flags usage inconsistent between the commits. But why the hell did you split even one function clearance into 2 commits? Why couldn't this commit be a part of the previous commit? Any why couldn't you delete the unused txn_..._flag() helpers along with their usage? On 22.01.2021 14:26, Cyrill Gorcunov via Tarantool-patches wrote: > Signed-off-by: Cyrill Gorcunov > --- > test/unit/snap_quorum_delay.cc | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/test/unit/snap_quorum_delay.cc b/test/unit/snap_quorum_delay.cc > index b9d4cc6c4..ec78f837d 100644 > --- a/test/unit/snap_quorum_delay.cc > +++ b/test/unit/snap_quorum_delay.cc > @@ -98,8 +98,7 @@ txn_process_func(va_list ap) > struct txn *txn = txn_begin(); > txn->fiber = fiber(); > /* Simulate a sync transaction. */ > - txn_set_flag(txn, TXN_WAIT_SYNC); > - txn_set_flag(txn, TXN_WAIT_ACK); > + txn->flags |= TXN_WAIT_SYNC | TXN_WAIT_ACK; > /* > * The true way to push the transaction to limbo is to call > * txn_commit() for sync transaction. But, if txn_commit() >