From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D8D13441841
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 26 Mar 2020 03:22:57 +0300 (MSK)
References: <cover.1585097339.git.korablev@tarantool.org>
 <6375dc2c8988baeab588dcf8fb19615441cb94e1.1585097339.git.korablev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <03cbfb56-0423-91f8-4394-9bd07a96660e@tarantool.org>
Date: Thu, 26 Mar 2020 01:22:56 +0100
MIME-Version: 1.0
In-Reply-To: <6375dc2c8988baeab588dcf8fb19615441cb94e1.1585097339.git.korablev@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 02/10] box: rename diag_add_error
 to diag_set_error
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

The commit LGTM. Lets push it right away.

On 25/03/2020 02:42, Nikita Pettik wrote:
> From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
> 
> Let's rename diag_add_error() to diag_set_error() because it actually
> replaces an error object in diagnostic area with a new one and this name
> is not representative. Moreover, we are going to introduce a new
> diag_add_error() which will place error at the top of stack diagnostic
> area.
> 
> Needed for #1148