From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AB1FC469710 for ; Sat, 6 Jun 2020 01:09:43 +0300 (MSK) From: "Timur Safin" References: In-Reply-To: Date: Sat, 6 Jun 2020 01:09:41 +0300 Message-ID: <03bb01d63b86$035fe140$0a1fa3c0$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Tarantool-patches] [PATCH 00/11] Enable miscelaneous sanitations List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Vladislav Shpilevoy' , tarantool-patches@dev.tarantool.org, alyapunov@tarantool.org I've looked into all patches of this patchset, and they look very much ok (especially the Guava story). Have no energy to send LGTM to each part, thus sending it for the whole set: LGTM Timur : From: Vladislav Shpilevoy : Subject: [PATCH 00/11] Enable miscelaneous sanitations : : The patchset is a second part of the undefined behaviour fixes. It : is based on the UB alignment patchset, and enables all the other : UB checks except a few last ones, described in the first commit. : : Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4609- : sanitize-misc-full-ci : Issue: https://github.com/tarantool/tarantool/issues/4609 : : Aleksandr Lyapunov (1): : salad: fix UB pointer arithmetics in bps_tree : : Vladislav Shpilevoy (10): : cmake: enable misc types of UB detection in clang : util: introduce double_compare_nint64() : test: avoid usleep() usage for error injections : vinyl: fix 0 division in case of canceled dump : xrow: don't cast double to float unconditionally : swim: fix zero division : test: fix signed integer overflow in vclock test : digest: eliminate UBs from guava() : sql: fix usage of not initialized index_stat : sql: fix mem_apply_type double type truncation : : cmake/compiler.cmake | 16 ++++++++++++++- : src/box/sql/vdbe.c | 18 +++++++++++------ : src/box/sql/vdbeaux.c | 16 +++++++-------- : src/box/sql/where.c | 4 ++-- : src/box/tuple_compare.cc | 9 ++------- : src/box/vy_regulator.c | 10 ++++++---- : src/box/vy_run.c | 2 +- : src/box/vy_scheduler.c | 2 +- : src/box/xrow_update_field.c | 19 +++++++++--------- : src/lib/core/util.c | 39 ++++++++++++++++++++++++++++++++++++- : src/lib/salad/bps_tree.h | 14 ++++++------- : src/lib/salad/guava.c | 18 ++++++++++------- : src/lib/salad/guava.h | 2 +- : src/lib/swim/swim.c | 10 +++++----- : src/lua/digest.lua | 2 +- : src/trivia/util.h | 29 +++++++++++++++++++++++++++ : test/app/digest.result | 2 +- : test/box/update.result | 2 +- : test/box/update.test.lua | 2 +- : test/unit/vclock.cc | 28 +++++++++++++------------- : test/unit/vclock.result | 2 +- : 21 files changed, 167 insertions(+), 79 deletions(-) : : -- : 2.21.1 (Apple Git-122.3)