From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 10C8A20A06 for ; Thu, 11 Jul 2019 10:12:39 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3t9kCkbDI8um for ; Thu, 11 Jul 2019 10:12:39 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C3BAF209FC for ; Thu, 11 Jul 2019 10:12:38 -0400 (EDT) From: imeevma@tarantool.org Subject: [tarantool-patches] [PATCH v1 1/1] box: do not check state in case of reconnect Date: Thu, 11 Jul 2019 17:12:35 +0300 Message-Id: <03b9fb9b57353762ee6b9c8fb12fc3dd4c177eb7.1562854125.git.imeevma@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: v.shpilevoy@tarantool.org Cc: avtikhon@tarantool.org, tarantool-patches@freelists.org Test box/net.box.test.lua checks state of the connection in case of an error. It should be 'error_reconnect'. But, in cases where testing was performed on a slow computer or in the case of a very large load, it is possible that the connection status may change from the 'error_reconnect' state to another state. This led to the failure of the test. Since this check is not the main purpose of the test, it is better to simply delete the check. Closes #4335 --- https://github.com/tarantool/tarantool/issues/4335 https://github.com/tarantool/tarantool/tree/imeevma/gh-4335-reconnect-state-error test/box/net.box.result | 4 ---- test/box/net.box.test.lua | 1 - 2 files changed, 5 deletions(-) diff --git a/test/box/net.box.result b/test/box/net.box.result index a18546d..92b6a2c 100644 --- a/test/box/net.box.result +++ b/test/box/net.box.result @@ -2818,10 +2818,6 @@ c.space.test:delete{1} _ = c._transport.perform_request(nil, nil, false, 'inject', nil, nil, nil, '\x80') --- ... -c.state ---- -- error_reconnect -... while not c:is_connected() do fiber.sleep(0.01) end --- ... diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua index 07558a0..e213d9a 100644 --- a/test/box/net.box.test.lua +++ b/test/box/net.box.test.lua @@ -1156,7 +1156,6 @@ c.space.test:delete{1} -- Break a connection to test reconnect_after. -- _ = c._transport.perform_request(nil, nil, false, 'inject', nil, nil, nil, '\x80') -c.state while not c:is_connected() do fiber.sleep(0.01) end c:ping() -- 2.7.4