From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 09418469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 13:18:55 +0300 (MSK)
References: <20201112195121.191366-1-gorcunov@gmail.com>
 <20201112195121.191366-12-gorcunov@gmail.com>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <03b93291-13c0-e334-b239-04055a314d77@tarantool.org>
Date: Fri, 13 Nov 2020 13:18:54 +0300
MIME-Version: 1.0
In-Reply-To: <20201112195121.191366-12-gorcunov@gmail.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH 11/11] raft: drop redundant argument
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>


12.11.2020 22:51, Cyrill Gorcunov пишет:
> It is never used and placed here accidentally.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>   src/box/raft.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/box/raft.c b/src/box/raft.c
> index ff664a4d1..3f175480c 100644
> --- a/src/box/raft.c
> +++ b/src/box/raft.c
> @@ -772,7 +772,7 @@ raft_sm_schedule_new_term(struct raft *raft, uint64_t new_term)
>   static void
>   raft_sm_schedule_new_vote(struct raft *raft, uint32_t new_vote)
>   {
> -	say_info("RAFT: vote for %u, follow", new_vote, raft->volatile_term);
> +	say_info("RAFT: vote for %u, follow", new_vote);
>   	assert(raft->volatile_vote == 0);
>   	assert(raft->leader == 0);
>   	assert(raft->state == RAFT_STATE_FOLLOWER);
LGTM

-- 
Serge Petrenko