From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
gorcunov@gmail.com,
"Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] box: make instace ro while limbo is not empty
Date: Tue, 1 Dec 2020 11:46:40 +0300 [thread overview]
Message-ID: <0393f979-091a-b25d-0e09-b4171320329f@tarantool.org> (raw)
In-Reply-To: <02a31724-3374-287e-b4b8-6ddd7134320b@tarantool.org>
01.12.2020 00:22, Vladislav Shpilevoy пишет:
> Hi! Thanks for the patch!
>
> On 30.11.2020 10:35, Serge Petrenko via Tarantool-patches wrote:
>> Users usually use box.ctl.wait_rw() to determine the moment when the
>> instance becomes writeable.
>> Since the synchronous replication introduction, this function became
>> pointless, because even when an instance is writeable, it may fail at
>> writing something because its limbo is not empty.
>> To fix the problem introduce a new helper, txn_limbo_is_ro() and start
>> using it in box_update_ro_summary().
>> Call bax_update_ro_summary() every time the limbo gets emptied out or
> bax -> box.
Thanks! Fixed.
>
>> changes an owner.
>>
>> Closes #5440
> Sasha (Tikh.), please, validate the branch is good to push.
--
Serge Petrenko
next prev parent reply other threads:[~2020-12-01 8:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 9:35 Serge Petrenko
2020-11-30 9:41 ` Serge Petrenko
2020-11-30 21:22 ` Vladislav Shpilevoy
2020-12-01 8:46 ` Serge Petrenko [this message]
2020-12-01 11:06 ` Alexander V. Tikhonov
2020-12-01 22:25 ` Vladislav Shpilevoy
2020-12-02 8:10 ` Serge Petrenko
2020-12-02 21:38 ` Vladislav Shpilevoy
2020-12-02 21:39 ` Vladislav Shpilevoy
2020-12-03 21:21 ` Vladislav Shpilevoy
2020-12-03 12:44 ` Alexander V. Tikhonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0393f979-091a-b25d-0e09-b4171320329f@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] box: make instace ro while limbo is not empty' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox