From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C68D068B30A; Tue, 3 Oct 2023 19:25:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C68D068B30A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1696350355; bh=b+bcN1M6nWj2304SB4WVyG3FxECl7Ou398iaPuDini8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=kM0BoPBs35MpM9lwxhnO15DKtoTbjMsJ52VAz4Uifb1JUiaQkmYqMps5jiGrCz9nU kNc54OmDF5/34Fe50dr8DZjRrITTBIgDLA6H8gW277eZYVNHTL7EVwY0vDtsZI+Y0w k7Xqk1hKokOCFHmT/L+09txAuQ4n8sc3MoYKM3YY= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B4ABF68B30A for ; Tue, 3 Oct 2023 19:25:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B4ABF68B30A Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qniDZ-0007kU-Qd; Tue, 03 Oct 2023 19:25:54 +0300 Message-ID: <038fe5c1-c421-78a4-02b1-2e0398010ce8@tarantool.org> Date: Tue, 3 Oct 2023 19:25:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: Maksim Kokryashkin , tarantool-patches@dev.tarantool.org, skaplun@tarantool.org, m.kokryashkin@tarantool.org References: <20231003133705.5700-1-max.kokryashkin@gmail.com> In-Reply-To: <20231003133705.5700-1-max.kokryashkin@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94A796AF4779ECFCE9B95D9E69024E5E7532DC59BEDF91C3D182A05F538085040CDF8D50DD0A890087E7E2D25346E3C95465697ABADB8341D295F984A9108EB50 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74060EE216B493874EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637826327602763C04B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85EB619A7D8FB2411084E7BC5B16036C8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC9FC99A4BA45EE8B4A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6C94F115956DE4A7A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5AF2A1A6EE7C89E63C3554C5E333C5983156C8419F6B21EE9F87CCE6106E1FC07E67D4AC08A07B9B082B967D547A19D2FCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C786159FDC4342B0605DB059B2EB2075614171B6390AF3825EBC665C5496FA98A7C94C40133E4A5C1D7E09C32AA3244C780D0EB2BD0A767801C5113E34A19279D9ADFF0C0BDB8D1FBAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojH0UbTrDsBkANmYreBKhfpw== X-DA7885C5: 836E7DF4FDB49056AA8063D8006713BA6E7838795EE4A4F6FA1F767658790B5F262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986BF14B90E598CC0A9B0CAE5F2AA12E8BDEDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] Mark CONV as non-weak, to prevent elimination of its side-effect. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 10/3/23 16:37, Maksim Kokryashkin wrote: > From: Mike Pall > > An unused guarded CONV int.num cannot be omitted in general. > > (cherry-picked from commit 881d02d3117838acaf4fb844332c8e33cc95c8c5) > > In some cases, an unused `CONV int.num` omission in `DUALNUM` mode I would add that DUALNUM could be enabled in CMake by "-DLUAJIT_NUMMODE=2" because it is not obvious and there is no documentation for CMake options. > may lead to a guard absence, resulting in invalid control flow > branching and undefined behavior. For a comprehensive example of > the described situation, please refer to the comment > in `test/tarantool-tests/mark-conv-non-weak.test.lua`.