From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BAC38A653E1; Tue, 26 Mar 2024 11:36:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BAC38A653E1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1711442183; bh=nsfGmWGvar6SfYf+2pUZTLkuEArmChNls0hyWH+Vi6c=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ufvgWTPa/nhhJyYT6vtWUH5VqjJWyXoxyHZYnSxZFKJj2RjaulFrbUyu6EI1zINJw F6f+JftPkavtyHjtSBvTpx3oYyGTyi1t0Qk3tRfU7zhmt4iDIvItZq5KAKfHEulIco RaMZ3uqJrO7ddIK7Le4Uw1vqxi1CRH93hzopXi7U= Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 854DDA653D4 for ; Tue, 26 Mar 2024 11:34:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 854DDA653D4 Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-51588f70d2dso6165181e87.3 for ; Tue, 26 Mar 2024 01:34:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711442069; x=1712046869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jzcDqTvDyAU+Av7XRgjyhrxUYnVhn0pI/nr2KX2YJeE=; b=RnuT325VbcT3c2YB46VdHc/Z225QNStT9nGgSVpxP9ZdmCEBK47qnU+BR0i7CBzNBX Qm7KVI9WO5r3QOIjXoq1LzeBOwnHIlNyeSqTdzZhYhSwdJCcsgHDEjg0FOHb9Qcb8t8Q VcOviA8OYCnfpe+LSqfvEES1lxZjhbqSSzw1dxGwU4CIvGmFiMaY3uLZvVTpfnfMmISQ yqY8gvP35gQj1ZnjvlgFxklVND60WuvCvETXcklMzzjqvdyV7L4XOSWBfrUnKuMLNcNP lw0+C5Dcds4okJ7CtBMBI1nvbZMQVT0ZjkpFWPL3Gm4PSf2N7GLpzR5OVXNAHpasIAwP Escg== X-Gm-Message-State: AOJu0YwhMqrU+84nVYZd6VWAaeQ0TeS8Oj5688FOB9C4fS63KWFTHaiO Kg8hB0ZmPcTCIrU4zL2zjqOhoIC6p2MY6VneSUZ9o8E80hDGcoYeaeZxW8in+qA= X-Google-Smtp-Source: AGHT+IF/nl/3/LlzppZrLICYKdDRVBVEO6k2cB+9bHGK4aCXCT+pQOvhbX+4R+lWMldfrhwSu4tMQg== X-Received: by 2002:a05:6512:4850:b0:515:9eaf:5c21 with SMTP id ep16-20020a056512485000b005159eaf5c21mr443514lfb.36.1711442069492; Tue, 26 Mar 2024 01:34:29 -0700 (PDT) Received: from pony.. ([5.181.62.126]) by smtp.gmail.com with ESMTPSA id y11-20020a056512044b00b005159c7939basm1434099lfk.185.2024.03.26.01.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 01:34:29 -0700 (PDT) To: tarantool-patches@dev.tarantool.org, Sergey Kaplun , Maxim Kokryashkin Date: Tue, 26 Mar 2024 11:33:30 +0300 Message-Id: <038a2581330cdd81b3aa4abb01f07aec0bab18c8.1711441864.git.sergeyb@tarantool.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH luajit 4/6] test: more cautious usage of LD_PRELOAD for ASan X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" From: Sergey Bronnikov This patch adds a comment for clarification about the usage of different versions of ASan implementations for different compilers. Also, it replaces ' ' with a ':' as a separator in `LD_PRELOAD` to make it more robust to the CMake list semantics and removes unnecessary double quotes. Needed for tarantool/tarantool#9656 Co-authored-by: Sergey Bronnikov --- test/LuaJIT-tests/CMakeLists.txt | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/test/LuaJIT-tests/CMakeLists.txt b/test/LuaJIT-tests/CMakeLists.txt index e8361e97..003f8de6 100644 --- a/test/LuaJIT-tests/CMakeLists.txt +++ b/test/LuaJIT-tests/CMakeLists.txt @@ -33,13 +33,19 @@ if(LUAJIT_USE_ASAN) # https://github.com/google/sanitizers/issues/934. LibRealPath(LIB_STDCPP libstdc++.so) # XXX: GCC requires both. Clang requires only libstdc++. + # Be aware, ASAN runtime in Clang on Linux was offered only in + # the form of a library with differ name from libasan.so (e.g. + # libclang_rt.asan-x86_64.a). + # See also: + # https://github.com/google/sanitizers/wiki/AddressSanitizerAsDso. if(CMAKE_C_COMPILER_ID STREQUAL "GNU") LibRealPath(LIB_ASAN libasan.so) - # XXX: Don't use " " (separator in LD_PRELOAD) in `list()`. - # ";" will expand to " " as we want. - list(APPEND LUAJIT_TESTS_ENV LD_PRELOAD="${LIB_ASAN};${LIB_STDCPP}") + # XXX: The items of the list in LD_PRELOAD can be separated + # by spaces or colons, and there is no support for escaping + # either separator, see ld.so(8). + list(APPEND LUAJIT_TESTS_ENV LD_PRELOAD=${LIB_ASAN}:${LIB_STDCPP}) else() - list(APPEND LUAJIT_TESTS_ENV LD_PRELOAD="${LIB_STDCPP}") + list(APPEND LUAJIT_TESTS_ENV LD_PRELOAD=${LIB_STDCPP}) endif() endif() -- 2.34.1